chore: librarian generate pull request: 20260108T223611Z #15011
Conversation
|
Adding We can remove the |
parthea
added
the
do not merge
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Compute Engine v1beta client library to reflect recent API changes, primarily by integrating new services and resources for VM extension policies, backend buckets, and health checks. It also enhances existing services with new methods and refines documentation for better usability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an automated update of the Compute Engine v1beta API client. The changes are extensive, adding new services and methods. My review focuses on the quality of the auto-generated code, particularly the docstrings. I've found numerous formatting issues in the docstrings across many files, such as missing spaces between words, which seems to be a systematic issue in the code generator. These issues affect the readability of the documentation. I've provided specific comments and suggestions to fix them. Please consider addressing the root cause in the generator to prevent these issues in future updates.
| can add to VM instances to improve or | ||
| accelerate performance when working with | ||
| intensive workloads. For more | ||
| information, readGPUs on Compute Engine. |
There was a problem hiding this comment.
There's a missing space in the docstring. It should be read GPUs on Compute Engine.
| information, readGPUs on Compute Engine. | |
| information, read GPUs on Compute Engine. |
| can add to VM instances to improve or | ||
| accelerate performance when working with | ||
| intensive workloads. For more | ||
| information, readGPUs on Compute Engine. |
There was a problem hiding this comment.
There's a missing space in the docstring. It should be read GPUs on Compute Engine.
| information, readGPUs on Compute Engine. | |
| information, read GPUs on Compute Engine. |
| Represents an IP Address resource. | ||
| Google Compute Engine has two IP Address resources: | ||
| \* [Global (external and | ||
| internal)](https://cloud.google.com/compute/docs/reference/rest/beta/globalAddresses) | ||
| \* [Regional (external and | ||
| internal)](https://cloud.google.com/compute/docs/reference/rest/beta/addresses) | ||
| For more information, see Reserving a static external | ||
| IP address. | ||
There was a problem hiding this comment.
The indentation in this docstring seems inconsistent and might lead to rendering issues. The paragraphs and the list items should be consistently indented relative to the google.cloud.compute_v1beta.types.Address: line.
| ) -> compute.Operation: | ||
| r"""Sets the labels on an Address. To learn more about | ||
| labels, read the Labeling Resources documentation. | ||
| labels, read theLabeling Resources documentation. |
There was a problem hiding this comment.
There's a missing space in the docstring. It should be read the Labeling Resources documentation.
| labels, read theLabeling Resources documentation. | |
| labels, read the Labeling Resources documentation. |
| API requests. For more information, readHandling API | ||
| responses. |
There was a problem hiding this comment.
There's a missing space in the docstring. It should be read Handling API responses.
| API requests. For more information, readHandling API | |
| responses. | |
| API requests. For more information, read Handling API | |
| responses. |
| You can use an operation resource to manage | ||
| asynchronous API requests. For more information, | ||
| readHandling API responses. |
There was a problem hiding this comment.
There's a missing space in the docstring. It should be read Handling API responses.
| readHandling API responses. | |
| asynchronous API requests. For more information, | |
| read Handling API responses. |
| method supportsPATCH semantics and usesJSON merge | ||
| patch format and processing rules. |
There was a problem hiding this comment.
There are missing spaces in the docstring. It should be supports PATCH and uses JSON.
| method supportsPATCH semantics and usesJSON merge | |
| patch format and processing rules. | |
| method supports PATCH semantics and uses JSON merge | |
| patch format and processing rules. |
| The name of thezone where the managed | ||
| instance group is located. The name | ||
| should conform to RFC1035. |
There was a problem hiding this comment.
There's a missing space in the docstring. It should be The name of the zone.
| The name of thezone where the managed | |
| instance group is located. The name | |
| should conform to RFC1035. | |
| The name of the zone where the managed | |
| instance group is located. The name | |
| should conform to RFC1035. |
| instance group. This method reduces thetargetSize of the | ||
| managed instance group by the number of instances that | ||
| you abandon. This operation is marked asDONE when the | ||
| action is scheduled even if the instances have not yet | ||
| been removed from the group. You must separately verify | ||
| the status of the abandoning action with | ||
| thelistmanagedinstances method. |
There was a problem hiding this comment.
There are several missing spaces in this docstring, for example thetargetSize, asDONE, and thelistmanagedinstances. This seems to be a recurring issue throughout the file.
| instance group. This method reduces thetargetSize of the | |
| managed instance group by the number of instances that | |
| you abandon. This operation is marked asDONE when the | |
| action is scheduled even if the instances have not yet | |
| been removed from the group. You must separately verify | |
| the status of the abandoning action with | |
| thelistmanagedinstances method. | |
| instance group. This method reduces the targetSize of the | |
| managed instance group by the number of instances that | |
| you abandon. This operation is marked as DONE when the | |
| action is scheduled even if the instances have not yet | |
| been removed from the group. You must separately verify | |
| the status of the abandoning action with | |
| the listmanagedinstances method. |
| configure a target for load balancing. | ||
| resource. | ||
| Instance Groups can be used to configure | ||
| a target forload balancing. |
There was a problem hiding this comment.
There's a missing space in the docstring. It should be for load balancing.
| a target forload balancing. | |
| configure a target for load balancing. |
parthea
removed
the
do not merge
|
The formatting issues exist in the upstream proto and need to be fixed there: https://raw.githubusercontent.com/googleapis/googleapis/refs/heads/master/google/cloud/compute/v1/compute.proto |
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1beta API to revision 20251210 (#1138)
PiperOrigin-RevId:
Library-IDs: google-cloud-compute-v1beta
Source-link: googleapis/googleapis@d4a34bf0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1beta API to revision 20251202
PiperOrigin-RevId:
Library-IDs: google-cloud-compute-v1beta
Source-link: googleapis/googleapis@a11bbeb4
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1beta API to revision 20251031
PiperOrigin-RevId:
Library-IDs: google-cloud-compute-v1beta
Source-link: googleapis/googleapis@db561899
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1beta API to revision 20251019
PiperOrigin-RevId:
Library-IDs: google-cloud-compute-v1beta
Source-link: googleapis/googleapis@ecb5d668
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@33225118
(exclusive) and
googleapis/googleapis@d4a34bf0
(inclusive).
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209