chore: librarian onboard pull request: 20251205T215603Z #14953

Linchin · 2025-12-05T21:56:42Z

PR created by the Librarian CLI to onboard a new Cloud Client Library.

BEGIN_COMMIT

feat: onboard a new library

PiperOrigin-RevId: 840720260
Library-IDs: google-cloud-maintenance

END_COMMIT

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:72e9b62c0f8f3799651ee62d777a2905f5b72ff19ea46f2e7b7d682d7d1e9414

snippet-bot · 2025-12-05T21:56:53Z

Here is the summary of changes.

You are about to add 6 region tags.

packages/google-cloud-maintenance/samples/generated_samples/maintenance_v1_generated_maintenance_get_resource_maintenance_async.py:26, tag maintenance_v1_generated_Maintenance_GetResourceMaintenance_async
packages/google-cloud-maintenance/samples/generated_samples/maintenance_v1_generated_maintenance_get_resource_maintenance_sync.py:26, tag maintenance_v1_generated_Maintenance_GetResourceMaintenance_sync
packages/google-cloud-maintenance/samples/generated_samples/maintenance_v1_generated_maintenance_list_resource_maintenances_async.py:26, tag maintenance_v1_generated_Maintenance_ListResourceMaintenances_async
packages/google-cloud-maintenance/samples/generated_samples/maintenance_v1_generated_maintenance_list_resource_maintenances_sync.py:26, tag maintenance_v1_generated_Maintenance_ListResourceMaintenances_sync
packages/google-cloud-maintenance/samples/generated_samples/maintenance_v1_generated_maintenance_summarize_maintenances_async.py:26, tag maintenance_v1_generated_Maintenance_SummarizeMaintenances_async
packages/google-cloud-maintenance/samples/generated_samples/maintenance_v1_generated_maintenance_summarize_maintenances_sync.py:26, tag maintenance_v1_generated_Maintenance_SummarizeMaintenances_sync

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

gemini-code-assist · 2025-12-05T21:57:52Z

Summary of Changes

Hello @Linchin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the onboarding of the new Python client library for the Google Cloud Maintenance API. It integrates the library into the existing repository structure by adding necessary configuration, generating client code, setting up documentation, and establishing development and testing infrastructure, ensuring the new API is fully supported and ready for use.

Highlights

New Client Library Onboarding: This pull request introduces a new Python client library for the Google Cloud Maintenance API, automatically generated and onboarded by the Librarian CLI.
Configuration Update: The .librarian/state.yaml file has been updated to include the configuration for the new google-cloud-maintenance library, defining its version, API paths, and file management rules.
Extensive File Additions: A comprehensive set of files has been added under packages/google-cloud-maintenance/, encompassing the core library, service clients, API type definitions, documentation, samples, and development tooling configurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request onboards the new google-cloud-maintenance client library. The changes are mostly auto-generated boilerplate. I've found a few typos in user-facing documentation and examples, and a critical issue with the package name in setup.py that needs to be addressed.

gemini-code-assist · 2025-12-05T21:59:14Z

packages/google-cloud-maintenance/setup.py

+
+package_root = os.path.abspath(os.path.dirname(__file__))
+
+name = "google-cloud-maintenance-api"


The package name should be google-cloud-maintenance, not google-cloud-maintenance-api. The -api suffix is typically reserved for the proto-only packages. The directory name and .repo-metadata.json both use google-cloud-maintenance.

Suggested change

name = "google-cloud-maintenance-api"

name = "google-cloud-maintenance"

gemini-code-assist · 2025-12-05T21:59:14Z

packages/google-cloud-maintenance/google/cloud/maintenance_api_v1/types/maintenance_service.py

+            - ``resource.resourceName=~"*/instance-20241212-211259"``
+            - ``maintenanceStartTime>"2000-10-11T20:44:51Z"``
+            - ``state="SCHEDULED" OR resource.type="compute.googleapis.com/Instance"``
+            - ``maintenance.maitenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND maintenanceCompleteTime>"2000-10-11T20:44:51Z"``


There's a typo in the filter example for maintenance.maintenanceName. "maitenanceName" should be "maintenanceName". An incorrect example could cause user confusion and errors.

Suggested change

- ``maintenance.maitenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND maintenanceCompleteTime>"2000-10-11T20:44:51Z"``

- ``maintenance.maintenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND maintenanceCompleteTime>"2000-10-11T20:44:51Z"``

gemini-code-assist · 2025-12-05T21:59:14Z

packages/google-cloud-maintenance/.repo-metadata.json

+{
+  "name": "google-cloud-maintenance",
+  "name_pretty": "Maintenance API",
+  "api_description": "The Maintenance API provides a centralized view of planned disruptive\nmaintenance events across supported Google Cloud products. It offers users\nvisibility into upcoming, ongoing, and completed maintenance, along with\ncontrols to manage certain maintenance activities, such as mainteance\nwindows, rescheduling, and on-demand updates.",


There's a typo in the api_description. "mainteance" should be "maintenance".

Suggested change

"api_description": "The Maintenance API provides a centralized view of planned disruptive\nmaintenance events across supported Google Cloud products. It offers users\nvisibility into upcoming, ongoing, and completed maintenance, along with\ncontrols to manage certain maintenance activities, such as mainteance\nwindows, rescheduling, and on-demand updates.",

"api_description": "The Maintenance API provides a centralized view of planned disruptive\nmaintenance events across supported Google Cloud products. It offers users\nvisibility into upcoming, ongoing, and completed maintenance, along with\ncontrols to manage certain maintenance activities, such as maintenance\nwindows, rescheduling, and on-demand updates.",

gemini-code-assist · 2025-12-05T21:59:14Z

packages/google-cloud-maintenance/README.rst

+controls to manage certain maintenance activities, such as mainteance
+windows, rescheduling, and on-demand updates.


There's a typo in the description. "mainteance" should be "maintenance".

Suggested change

controls to manage certain maintenance activities, such as mainteance

windows, rescheduling, and on-demand updates.

controls to manage certain maintenance activities, such as maintenance

windows, rescheduling, and on-demand updates.

gemini-code-assist · 2025-12-05T21:59:14Z

packages/google-cloud-maintenance/docs/README.rst

+controls to manage certain maintenance activities, such as mainteance
+windows, rescheduling, and on-demand updates.


There's a typo in the description. "mainteance" should be "maintenance". This file appears to be a copy of the root README, so the fix should be applied here as well.

Suggested change

controls to manage certain maintenance activities, such as mainteance

windows, rescheduling, and on-demand updates.

controls to manage certain maintenance activities, such as maintenance

windows, rescheduling, and on-demand updates.

parthea · 2025-12-17T16:22:29Z

This package was created as google-cloud-maintenance but it should be google-cloud-maintenance-api (see https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-maintenance-api)

feat: generate libraries

301998f

Linchin requested review from a team as code owners December 5, 2025 21:56

gemini-code-assist bot reviewed Dec 5, 2025

View reviewed changes

parthea closed this Dec 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: librarian onboard pull request: 20251205T215603Z #14953

chore: librarian onboard pull request: 20251205T215603Z #14953

Uh oh!

Linchin commented Dec 5, 2025

Uh oh!

snippet-bot bot commented Dec 5, 2025

Uh oh!

gemini-code-assist bot commented Dec 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 5, 2025

Uh oh!

gemini-code-assist bot Dec 5, 2025

Uh oh!

gemini-code-assist bot Dec 5, 2025

Uh oh!

gemini-code-assist bot Dec 5, 2025

Uh oh!

gemini-code-assist bot Dec 5, 2025

Uh oh!

parthea commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		package_root = os.path.abspath(os.path.dirname(__file__))

		name = "google-cloud-maintenance-api"

	name = "google-cloud-maintenance-api"
	name = "google-cloud-maintenance"

	- ``maintenance.maitenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND maintenanceCompleteTime>"2000-10-11T20:44:51Z"``
	- ``maintenance.maintenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND maintenanceCompleteTime>"2000-10-11T20:44:51Z"``

	"api_description": "The Maintenance API provides a centralized view of planned disruptive\nmaintenance events across supported Google Cloud products. It offers users\nvisibility into upcoming, ongoing, and completed maintenance, along with\ncontrols to manage certain maintenance activities, such as mainteance\nwindows, rescheduling, and on-demand updates.",
	"api_description": "The Maintenance API provides a centralized view of planned disruptive\nmaintenance events across supported Google Cloud products. It offers users\nvisibility into upcoming, ongoing, and completed maintenance, along with\ncontrols to manage certain maintenance activities, such as maintenance\nwindows, rescheduling, and on-demand updates.",

		controls to manage certain maintenance activities, such as mainteance
		windows, rescheduling, and on-demand updates.

chore: librarian onboard pull request: 20251205T215603Z #14953

chore: librarian onboard pull request: 20251205T215603Z #14953

Uh oh!

Conversation

Linchin commented Dec 5, 2025

Uh oh!

snippet-bot bot commented Dec 5, 2025

Uh oh!

gemini-code-assist bot commented Dec 5, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

parthea commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants