Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using WhichOneof when parsing a Value protobuf. #1462

Merged

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 13, 2016

NOTE: Has #1461 as diffbase.

Relates to discussion in #1402.

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Feb 13, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2016
@theacodes
Copy link
Contributor

LGTM

dhermes added a commit that referenced this pull request Feb 13, 2016
Using WhichOneof when parsing a Value protobuf.
@dhermes dhermes merged commit 302c1a0 into googleapis:datastore-v1beta3 Feb 13, 2016
@dhermes dhermes deleted the v1beta3-use-whichoneof branch February 13, 2016 07:15
if value_pb.HasField('timestamp_value'):
value_type = value_pb.WhichOneof('value_type')

if value_type == 'timestamp_value':

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants