Skip to content

feat: [google-cloud-secret-manager] update secret manager protos for tags #13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchudnov-g merged 2 commits into from
Jun 5, 2025
Merged

feat: [google-cloud-secret-manager] update secret manager protos for tags #13976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cefd24
feat: update secret manager protos for tags
gcf-owl-bot[bot] Jun 5, 2025
438eac9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/google-cloud-secret-manager/google/cloud/secretmanager_v1/types/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,18 @@ class Secret(proto.Message):
added afterwards. They do not apply retroactively to
existing
[SecretVersions][google.cloud.secretmanager.v1.SecretVersion].
tags (MutableMapping[str, str]):
Optional. Input only. Immutable. Mapping of
Tag keys/values directly bound to this resource.
For example:

"123/environment": "production",
"123/costCenter": "marketing"

Tags are used to organize and group resources.

Tags can be used to control policy evaluation
for the resource.
"""

name: str = proto.Field(
Expand Down Expand Up @@ -222,6 +234,11 @@ class Secret(proto.Message):
number=15,
message="CustomerManagedEncryption",
)
tags: MutableMapping[str, str] = proto.MapField(
proto.STRING,
proto.STRING,
number=16,
)


class SecretVersion(proto.Message):
Expand Down
2 changes: 2 additions & 0 deletions ...gle-cloud-secret-manager/tests/unit/gapic/secretmanager_v1/test_secret_manager_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10302,6 +10302,7 @@ def test_create_secret_rest_call_success(request_type):
"annotations": {},
"version_destroy_ttl": {},
"customer_managed_encryption": {},
"tags": {},
}
# The version of a generated dependency at test runtime may differ from the version used during generation.
# Delete any fields which are not present in the current runtime dependency
Expand Down Expand Up @@ -10778,6 +10779,7 @@ def test_update_secret_rest_call_success(request_type):
"annotations": {},
"version_destroy_ttl": {},
"customer_managed_encryption": {},
"tags": {},
}
# The version of a generated dependency at test runtime may differ from the version used during generation.
# Delete any fields which are not present in the current runtime dependency
Expand Down
Loading