Skip to content

Bringing auto-gen import re-writing up to date with files. #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhermes merged 1 commit into from
Dec 22, 2015
Merged

Bringing auto-gen import re-writing up to date with files. #1316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/rewrite_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ def transform_old_to_new(line, old_module, new_module,
"from {old_module} import ..."
then checks if the line contains
"import {old_module} ..."
and finally checks if the line starts with (ignoring whitespace)
then checks if the line starts with (ignoring whitespace)
"{old_module} ..."
and finally checks if the line contians
"'some-dict-key': {old_module} ..."

In any of these cases, "{old_module}" is replaced with "{new_module}".
If none match, nothing is returned.
Expand Down Expand Up @@ -96,6 +98,11 @@ def transform_old_to_new(line, old_module, new_module,
# Only replace the first instance of the old_module.
return line.replace(old_module, new_module, 1)

# Finally check for usage in dictionaries.
if ': ' + old_module in line:
# Only replace the first instance of the old_module.
return line.replace(': ' + old_module, ': ' + new_module, 1)


def transform_line(line):
"""Transforms an import line in a PB2 module.
Expand Down