Skip to content

Commit

Permalink
chore: clean up owlbot post-processing (#5856)
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer authored Feb 10, 2023
1 parent 98fc50b commit 3cade16
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,23 +32,6 @@

php.owlbot_main(src=src, dest=dest)

# document and utilize apiEndpoint instead of serviceAddress
s.replace(
"**/Gapic/*GapicClient.php",
r"'serviceAddress' =>",
r"'apiEndpoint' =>")
s.replace(
"**/Gapic/*GapicClient.php",
r"@type string \$serviceAddress\n\s+\*\s+The address",
r"""@type string $serviceAddress
* **Deprecated**. This option will be removed in a future major release. Please
* utilize the `$apiEndpoint` option instead.
* @type string $apiEndpoint
* The address""")
s.replace(
"**/Gapic/*GapicClient.php",
r"\$transportConfig, and any \$serviceAddress",
r"$transportConfig, and any `$apiEndpoint`")

### [START] protoc backwards compatibility fixes

Expand All @@ -60,12 +43,6 @@
*/
private $""")

# prevent proto messages from being marked final
s.replace(
"src/**/V*/**/*.php",
r"final class",
r"class")

# Replace "Unwrapped" with "Value" for method names.
s.replace(
"src/**/V*/**/*.php",
Expand Down

0 comments on commit 3cade16

Please sign in to comment.