fix regression tests. #402

stephenplusplus · 2015-02-19T20:12:03Z

Our merge of #388 didn't end up helping our regression tests. Well, it may have, but it seems a new one has popped up.

When I run locally, I don't get the error, but Travis does. It gets an error in one of the many functions being called in a before hook. So, I started looking deeper into what the troubled hook does, and questioned what was necessary so that it could be uncomplicated.

This PR includes my findings.

regression/pubsub.js

+
+function generateSubName() {
+  return 'test-subscription-' + uuid.v4();
+}


ryanseys · 2015-02-19T20:40:27Z

Yay! Can you write a comment here so that developers know that deleting a topic will destroy all subscriptions for that topic?

stephenplusplus · 2015-02-19T20:40:54Z

👍

lib/pubsub/topic.js

@@ -152,7 +152,7 @@ Topic.prototype.publish = function(messages, callback) {
 };

 /**
- * Delete the topic.
+ * Delete the topic. This will also delete any subscriptions to this topic.


ryanseys · 2015-02-19T20:44:26Z

LGTM! 🚂 Here goes!

fix regression tests.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/e2b098f4-76c4-4fe5-820c-ae293231f7bd/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@0c868d4

* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(nodejs_templates): add script logging to node_library populate-secrets.sh Co-authored-by: Benjamin E. Coe <[email protected]> Source-Author: BenWhitehead <[email protected]> Source-Date: Wed Jun 10 22:24:28 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: e7034945fbdc0e79d3c57f6e299e5c90b0f11469 Source-Link: googleapis/synthtool@e703494

🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.3](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.2...v3.1.3) (2020-11-25) ### Bug Fixes * check for fetch on window ([#401](https://www.github.com/googleapis/nodejs-os-login/issues/401)) ([e2547a9](https://www.github.com/googleapis/nodejs-os-login/commit/e2547a90031a46a4ad044318c26c160d8fb04ff6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/d5e01c0b-0d2d-4da4-b495-86674ea6021f/targets

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped) | devDependencies | major | [`^7.0.1` -> `^8.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/7.0.2/8.0.0) | --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dataproc).

🤖 I have created a release \*beep\* \*boop\* --- ## [2.2.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v2.1.2...v2.2.0) (2020-11-25) ### Features * update GKE v1 API ([#401](https://www.github.com/googleapis/nodejs-cloud-container/issues/401)) ([f72f121](https://www.github.com/googleapis/nodejs-cloud-container/commit/f72f1210f63e1fd9b3dd02e0791b1d024d1cbe07)) ### Bug Fixes * **browser:** check for fetch on window ([#403](https://www.github.com/googleapis/nodejs-cloud-container/issues/403)) ([40f207e](https://www.github.com/googleapis/nodejs-cloud-container/commit/40f207e3e1ae02f63b9b34c9e957c0caae89c7fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/bea77be5-6371-49cb-b1fc-88500cc4fade/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@901ddd4 Source-Link: googleapis/synthtool@f96d3b4

…sts (#402) * refactor(test): use exponential backoff and retry for integration tests * chore: remove p-retry dependency, in favor of this.retries * chore: slight tweak to retry logic * chore: add stagger as suggested

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/e2b098f4-76c4-4fe5-820c-ae293231f7bd/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@0c868d4

…andwritten libraries (#402) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9

fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e

🤖 I have created a release \*beep\* \*boop\* --- ### [5.3.3](https://www.github.com/googleapis/nodejs-security-center/compare/v5.3.2...v5.3.3) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#400](https://www.github.com/googleapis/nodejs-security-center/issues/400)) ([0f35393](https://www.github.com/googleapis/nodejs-security-center/commit/0f35393b8e64fdabc170eb264de5e5a54a0c6f2e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/041f5df7-f5d3-4b2a-9ede-0752bf41c185/targets

🤖 I have created a release \*beep\* \*boop\* --- ### [2.0.2](https://www.github.com/googleapis/nodejs-dns/compare/v2.0.1...v2.0.2) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#401](https://www.github.com/googleapis/nodejs-dns/issues/401)) ([c02a9da](https://www.github.com/googleapis/nodejs-dns/commit/c02a9daa5290922928f313a59a59af0f244d8eb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

fix regression tests.

607638c

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2015

stephenplusplus reviewed Feb 19, 2015
View reviewed changes

regression/pubsub.js

function generateSubName() {

return 'test-subscription-' + uuid.v4();

}

This comment was marked as spam.

Sign in to view

fix getSubscriptions

32b7c25

stephenplusplus force-pushed the spp--regression-test-fixes branch from 0105339 to 32b7c25 Compare February 19, 2015 20:28

stephenplusplus mentioned this pull request Feb 19, 2015

Release 0.13.0? #382

Closed

explain deleting a topic will delete subscriptions

8713566

stephenplusplus reviewed Feb 19, 2015
View reviewed changes

lib/pubsub/topic.js

@@ -152,7 +152,7 @@ Topic.prototype.publish = function(messages, callback) {

};

/**

* Delete the topic.

* Delete the topic. This will also delete any subscriptions to this topic.

This comment was marked as spam.

Sign in to view

ryanseys added a commit that referenced this pull request Feb 19, 2015

Merge pull request #402 from stephenplusplus/spp--regression-test-fixes

b8dff43

fix regression tests.

ryanseys merged commit b8dff43 into googleapis:master Feb 19, 2015

snyk-bot mentioned this pull request Jan 29, 2022

[Snyk] Upgrade gaxios from 3.2.0 to 4.3.2 RebelTat/google-cloud-node#3

Open

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

release-please bot mentioned this pull request Sep 15, 2022

chore: release main #3352

Merged

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 27, 2022

feat: expose logo recognition API proto for GA (#402)

2f83bd6

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Nov 9, 2022

feat: expose logo recognition API proto for GA (#402)

3613bc1

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

sofisl pushed a commit that referenced this pull request Nov 10, 2022

chore: linting rules (#402)

c1bfa78

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/d5e01c0b-0d2d-4da4-b495-86674ea6021f/targets

sofisl pushed a commit that referenced this pull request Nov 10, 2022

build: remove unused codecov config (#402)

11e23ce

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-dataproc #3533

Merged

migrate code from googleapis/nodejs-cloud-container #3543

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-scheduler #3547

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: disable renovate dependency dashboard (#1194) (#402)

8b215c3

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-asset #3567

Merged

migrate code from googleapis/nodejs-talent #3568

Merged

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

build: update protos.js (#402)

2b2adda

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/041f5df7-f5d3-4b2a-9ede-0752bf41c185/targets

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix regression tests. #402

fix regression tests. #402

stephenplusplus commented Feb 19, 2015

This comment was marked as spam.

ryanseys commented Feb 19, 2015

stephenplusplus commented Feb 19, 2015

This comment was marked as spam.

ryanseys commented Feb 19, 2015

fix regression tests. #402

fix regression tests. #402

Conversation

stephenplusplus commented Feb 19, 2015

This comment was marked as spam.

ryanseys commented Feb 19, 2015

stephenplusplus commented Feb 19, 2015

This comment was marked as spam.

ryanseys commented Feb 19, 2015