datastore: concat transactional mutations #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lib/datastore/transaction.js
Outdated
| }, {}); | ||
|
|
||
| var reqOpts = { | ||
| mutations: this.requests_.reduce(function(acc, req) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Any reason why we can't add a e2e test for this? |
| // IDs to incomplete keys. | ||
| .sort(function(a, b) { | ||
| return a.method > b.method ? 1 : a.method < b.method ? -1 : 0; | ||
| return a.method < b.method ? 1 : a.method > b.method ? -1 : 0; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
In place of this, I just fixed the system test. It previously was deleting something that never existed, which was giving false positives. Now, we create that entity before deleting it. |
|
Changes Unknown when pulling 77cbb3a on stephenplusplus:spp--1339 into * on GoogleCloudPlatform:master*. |
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
* Add descriptions for some query parameters * Eliminate the extra space * Add a description to all the alias parameters * Add documentation for property parameters * Add descriptions for the aggregation argument * Add property params to these objects * Add descriptions for data types * Fix the broken links * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Kevin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339