Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token expiration broken when using GCE service accounts #212

Closed
silvolu opened this issue Sep 16, 2014 · 1 comment · Fixed by #213
Closed

token expiration broken when using GCE service accounts #212

silvolu opened this issue Sep 16, 2014 · 1 comment · Fixed by #213
Assignees
@stephenplusplus
Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Core Stable

Comments

@silvolu
Copy link
Contributor

silvolu commented Sep 16, 2014

The access token expiration is computed using the value of the token_expires field of the token, but the access token returned by GCE service accounts doesn't contain such field, only expires_in.
@stephenplusplus stephenplusplus self-assigned this Sep 17, 2014
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue Sep 17, 2014
@stephenplusplus
fix(connection): set token expiration date for GCE
e44cfbd 
A response from the GCE metadata server responds with data in a
different format from that of the GAPIToken() request. Instead of
looking for a property that doesn't exist `token_expires`, we now
calculate the expiration timestamp from `expires_in`.

For more, see [Authenticating from Google Compute Engine][auth].

[auth]:https://developers.google.com/compute/docs/authentication#applications

Fixes googleapis#212
@stephenplusplus stephenplusplus mentioned this issue Sep 17, 2014
Merged
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue Sep 17, 2014
@stephenplusplus
fix(connection): set token expiration date for GCE
8be5e2d 
A response from the GCE metadata server responds with data in a
different format from that of the GAPIToken() request. Instead of
looking for a property that doesn't exist `token_expires`, we now
calculate the expiration timestamp from `expires_in`.

For more, see [Authenticating from Google Compute Engine][auth].

[auth]:https://developers.google.com/compute/docs/authentication#applications

Fixes googleapis#212
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue Sep 17, 2014
@stephenplusplus
fix(connection): set token expiration date for GCE
ec5f537 
A response from the GCE metadata server responds with data in a
different format from that of the GAPIToken() request. Instead of
looking for a property that doesn't exist `token_expires`, we now
calculate the expiration timestamp from `expires_in`.

For more, see [Authenticating from Google Compute Engine][auth].

[auth]:https://developers.google.com/compute/docs/authentication#applications

Fixes googleapis#212
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue Sep 17, 2014
@stephenplusplus
fix(connection): set token expiration date for GCE
9ab8488 
A response from the GCE metadata server responds with data in a
different format from that of the GAPIToken() request. Instead of
looking for a property that doesn't exist `token_expires`, we now
calculate the expiration timestamp from `expires_in`.

For more, see [Authenticating from Google Compute Engine][auth].

[auth]:https://developers.google.com/compute/docs/authentication#applications

Fixes googleapis#212
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue Sep 17, 2014
@stephenplusplus
fix(connection): set token expiration date for GCE
2eb9903 
A response from the GCE metadata server responds with data in a
different format from that of the GAPIToken() request. Instead of
looking for a property that doesn't exist `token_expires`, we now
calculate the expiration timestamp from `expires_in`.

For more, see [Authenticating from Google Compute Engine][auth].

[auth]:https://developers.google.com/compute/docs/authentication#applications

Fixes googleapis#212
o-klp added a commit to o-klp/gcloud-node that referenced this issue Sep 19, 2014
@o-klp
fix(connection) changed token expiration calculation - issue googleap…
6e2dbf8 
…is#212
o-klp added a commit to o-klp/gcloud-node that referenced this issue Sep 19, 2014
@o-klp
fix(connection) changed token expiration calculation - issue googleap…
eb9c5d9 
…is#212
@o-klp o-klp mentioned this issue Sep 19, 2014
Closed
@o-klp
Copy link

o-klp commented Sep 19, 2014

Fixed and issued pull request: https://github.com/GoogleCloudPlatform/gcloud-node/issues

@jgeewax jgeewax added auth type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 2, 2015
@jgeewax jgeewax added this to the Core Stable milestone Feb 2, 2015
@snyk-bot snyk-bot mentioned this issue Jan 31, 2020
Open
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
@snyk-bot snyk-bot mentioned this issue Aug 16, 2020
Open
@sofisl sofisl mentioned this issue Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 16, 2022
@JustinBeckwith @bcoe
build: use config file for linkinator (#212)
9c5fc23
sofisl pushed a commit that referenced this issue Oct 5, 2022
@JustinBeckwith @bcoe
build: use config file for linkinator (#212)
818104e
@sofisl sofisl mentioned this issue Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 5, 2022
@JustinBeckwith @bcoe
build: use config file for linkinator (#212)
2445d46
@sofisl sofisl mentioned this issue Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 8, 2022
@JustinBeckwith @bcoe
build: use config file for linkinator (#212)
9fe9b22
This was referenced Oct 11, 2022
Merged
Merged
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@JustinBeckwith @bcoe
build: use config file for linkinator (#212)
f4fc4e6
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@JustinBeckwith
build: create docs test npm scripts (#212)
cd2b916
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@JustinBeckwith
chore: remove unused deps (#212)
0a18c74
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-merge-on-green
feat: deferred client initialization (#212)
84d1c74 
This PR includes changes from googleapis/gapic-generator-typescript#317
that will move the asynchronous initialization and authentication from the client constructor
to an `initialize()` method. This method will be automatically called when the first RPC call
is performed.

The client library usage has not changed, there is no need to update any code.

If you want to make sure the client is authenticated _before_ the first RPC call, you can do
```js
await client.initialize();
```
manually before calling any client method.
sofisl pushed a commit that referenced this issue Nov 11, 2022
@yoshi-automation
build: update protos (#212)
c94cdbe 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/b205fd33-200c-4298-88b8-18b0d1c79a3e/targets

- [ ] To automatically regenerate this PR, check this box.
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@yoshi-automation
build: add v1.GrafeasClient type (#212)
9eb1792
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
docs(samples): include metadata file, add exclusions for samples to h…
03f9e1d 
…andwritten libraries (#212)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 429395631

Source-Link: googleapis/googleapis@84594b3

Source-Link: googleapis/googleapis-gen@ed74f97
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: new owl bot post processor docker image (#212)
bcfd612 
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please @gcf-owl-bot
chore(main): release 2.1.0 (#212)
11f27c2 
* chore(main): release 2.1.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@yoshi-automation @JustinBeckwith
docs: Remove a broken link from the documentation. (#212)
3ca3472 
PiperOrigin-RevId: 314792023

Source-Author: Google APIs <[email protected]>
Source-Date: Thu Jun 4 13:24:33 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 8070bcb140b06991a636d4ba7d665c5adab1675d
Source-Link: googleapis/googleapis@8070bcb

Co-authored-by: Justin Beckwith <[email protected]>
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot @bcoe
feat: added the display name of the current page in webhook requests (#…
b03651c 
…212)

PiperOrigin-RevId: 417856932
Source-Link: googleapis/googleapis@16ecf07
Source-Link: googleapis/googleapis-gen@d295521
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDI5NTUyMTliNjVmYjdmNDdmY2U5NmM5M2RmYmYyNWMyZmRlMWQ4MiJ9
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <[email protected]>
sofisl pushed a commit that referenced this issue Jan 26, 2023
@gcf-owl-bot
build(node): update deps used during postprocessing (#1243) (#212)
0fe5947 
Fixes #1008
Source-Link: googleapis/synthtool@b0535a7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bbb8dd6576ac58830a07fc17e9511ae898be44f2219d3344449b125df9854441

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Jan 26, 2023
Merged
4 tasks
@sofisl sofisl mentioned this issue Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 13, 2023
@yoshi-automation @JustinBeckwith
chore: release 1.2.3 (#212)
24a7f73 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Sep 14, 2023
@callmehiphop @JustinBeckwith
docs: update contributing path in README (#212)
4a0ade3
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Core Stable
Development

Successfully merging a pull request may close this issue.

fix(connection): set token expiration date for GCE stephenplusplus/gcloud-node
6 participants
@jgeewax @beriberikix @silvolu @stephenplusplus @o-klp @yoshi-automation