Skip to content

Conversation

@renovate-bot
Copy link
Contributor

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-shared-dependencies 3.11.0 -> 3.12.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@zhumin8
Copy link
Contributor

zhumin8 commented Jun 22, 2023

Check failing with error:

Error:  Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce) on project google-cloud-notification: 
Error:  Rule 2: org.apache.maven.enforcer.rules.dependency.RequireUpperBoundDeps failed with message:
Error:  Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Error:  Require upper bound dependencies error for com.google.j2objc:j2objc-annotations:1.3 paths to dependency are:
Error:  +-com.google.cloud:google-cloud-notification:0.138.0-beta-SNAPSHOT
Error:    +-com.google.cloud:google-cloud-storage:2.22.4
Error:      +-com.google.j2objc:j2objc-annotations:1.3
Error:  and
Error:  +-com.google.cloud:google-cloud-notification:0.138.0-beta-SNAPSHOT
Error:    +-com.google.api.grpc:proto-google-cloud-pubsub-v1:1.105.14
Error:      +-com.google.j2objc:j2objc-annotations:1.3
Error:  and
Error:  +-com.google.cloud:google-cloud-notification:0.138.0-beta-SNAPSHOT
Error:    +-com.google.guava:guava:32.0.1-jre
Error:      +-com.google.j2objc:j2objc-annotations:2.8
Error:  ]

@suztomo So google-cloud-notification depends on storage and pubsub. In this case, to fix this, we wait for storage and pubsub to release with the new shared-dependencies first, then update here. Am I understanding this right?
Update: storage is not releasing with shared-dependencies 3.12.0. Should we temporary exclude j2objc-annotations from storage as in googleapis/sdk-platform-java#1791? What do you think? Watch for storage 2.22.5 release

@suztomo
Copy link
Member

suztomo commented Jun 22, 2023

Should we temporary exclude j2objc-annotations from storage as in googleapis/sdk-platform-java#1791? What do you think?

The temporary exclusion makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants