Skip to content

chore: Fixing stuff and root_versions script #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddixit14 merged 1 commit into from
Nov 14, 2022
Merged

chore: Fixing stuff and root_versions script #8774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions generation/generate_root_versions_txt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
#!/bin/bash

# This script adds the contents of a module's versions.txt to root versions.txt and then deletes it.
# This should be run during addition of a new-module to the monorepo

set -e

GENERATION_DIR=$(dirname -- "$0")

rm -f versions.txt

echo "# Format:" >> versions.txt
echo "# module:released-version:current-version" >> versions.txt

module_list=$(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort --dictionary-order |xargs dirname)

for path in $module_list; do

cat ${path}/versions.txt | while read LINE; do
if ! [[ $LINE == *"#"* ]] && [ "$LINE" != "" ]; then
echo $LINE >> versions.txt
fi
done

FILE=${path}/versions.txt
if [ -f ${FILE} ]; then
cat ${path}/versions.txt | while read LINE; do
if ! [[ $LINE == *"#"* ]] && [ "$LINE" != "" ]; then
echo $LINE >> versions.txt
fi
done
fi
rm -f ${FILE}
done

2 changes: 1 addition & 1 deletion java-kms/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-kms-bom</artifactId>
<version>2.8.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-kms-bom:current} -->
<version>2.8.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-kms:current} -->
</dependency>
</dependencies>
</dependencyManagement>
Expand Down
1 change: 1 addition & 0 deletions versions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,3 +587,4 @@ grpc-google-cloud-workflows-v1beta:0.11.0:0.11.1-SNAPSHOT
grpc-google-cloud-workflows-v1:2.5.0:2.5.1-SNAPSHOT
proto-google-cloud-workflows-v1beta:0.11.0:0.11.1-SNAPSHOT
proto-google-cloud-workflows-v1:2.5.0:2.5.1-SNAPSHOT
google-cloud-dns:2.3.0:2.3.1-SNAPSHOT