Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pubsub publish and pull package-private #1544

Merged
merged 1 commit into from
Jan 18, 2017
Merged

make pubsub publish and pull package-private #1544

merged 1 commit into from
Jan 18, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Jan 18, 2017

This reflects the changes in googleapis/googleapis#241 but pulls in other changes that landed in master by #1501

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 83.149% when pulling ffa822b on pongad:package-private into 19acb03 on GoogleCloudPlatform:pubsub-rm.

@garrettjonesgoogle
Copy link
Member

LGTM

@garrettjonesgoogle
Copy link
Member

Hmm it looks like the Travis Mac run had the same failure as another of your PRs.

@pongad
Copy link
Contributor Author

pongad commented Jan 18, 2017

As discussed, we can merge to pubsub-hp, but we'll definitely hold off merging to master until we fix the flakes.

@pongad pongad merged commit 1f68932 into googleapis:pubsub-rm Jan 18, 2017
@pongad pongad deleted the package-private branch January 18, 2017 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pongad @coveralls @garrettjonesgoogle @googlebot