Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix more races in pubsub tests #1473

Merged
merged 1 commit into from
Dec 12, 2016
Merged

fix more races in pubsub tests #1473

merged 1 commit into from
Dec 12, 2016

Commits on Dec 12, 2016

  1. fix more races in pubsub tests 

    Previously BlockingProcessStreamReader has a terminate() method,
used to tell the Reader to stop reading from the emulator process.

This causes an inter-process race.
If the Reader stops before reading emulator's output,
the emulator process will hang as it tries to write to stdout/stderr
as there's no one to read from the other side of the pipe.

Since there is no way to safely stop the Reader,
this commit deletes the method and its associated test.

Additionally, the timeout for LocalSystemTest is increased to 3 minutes,
since the emulator, somehow, consistently takes just longer than a
minute to shut down.
    @pongad
    pongad committed Dec 12, 2016
    Configuration menu
    Copy the full SHA
    9a308a2 View commit details
    Browse the repository at this point in the history