Skip to content

fix: add retry behavior documentation to insertall interface to clarify the behavior #14058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaoleMeng merged 6 commits into from
Aug 12, 2026
Merged

fix: add retry behavior documentation to insertall interface to clarify the behavior #14058

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
30f4a25
fix: add documentation for insertall api that there's no default retry
GaoleMeng Jul 29, 2026
597429c
Merge branch 'main' into main
GaoleMeng Aug 3, 2026
4a46d32
Add comment
GaoleMeng Aug 3, 2026
cde12cc
Merge branch 'googleapis:main' into main
GaoleMeng Aug 12, 2026
dca13e7
Add comment for InsertAll retry behavior to interface
GaoleMeng Aug 12, 2026
9cb7476
format
GaoleMeng Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,6 +1355,9 @@ public int hashCode() {
* Sends an insert all request.
*
* <p>Example of inserting rows into a table without running a load job.
* To prevent duplicate rows, this method does not perform automatic retries unless
* insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and
* should be handled by the caller when insert IDs are not provided.

@gemini-code-assist gemini-code-assist Bot Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The retry behavior explanation is currently placed directly inside the paragraph describing the example, interrupting the flow between the example description and the actual code block. Separating the retry behavior note into its own paragraph before the example improves readability and structure.

Suggested change
* <p>Example of inserting rows into a table without running a load job.
* To prevent duplicate rows, this method does not perform automatic retries unless
* insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and
* should be handled by the caller when insert IDs are not provided.
* <p>To prevent duplicate rows, this method does not perform automatic retries unless
* insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and
* should be handled by the caller when insert IDs are not provided.
*
* <p>Example of inserting rows into a table without running a load job.

*
* <pre>{@code
* String datasetName = "my_dataset_name";
Expand Down
Loading