Skip to content

fix(bigtable): remove heartbeat miss logging - #14054

Merged
mutianf merged 1 commit into
googleapis:mainfrom
mutianf:hb
Aug 12, 2026
Merged

fix(bigtable): remove heartbeat miss logging#14054
mutianf merged 1 commit into
googleapis:mainfrom
mutianf:hb

Conversation

@mutianf

@mutianf mutianf commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

We already capture heartbeat closes in close reason. So this is visible from server side metrics. Logging warning could spam application logs.

@mutianf
mutianf requested review from a team as code owners August 12, 2026 14:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a warning log statement that was previously triggered when a missed heartbeat forced a session to close in SessionImpl.java. There are no review comments, and I have no additional feedback to provide.

@mutianf
mutianf merged commit ec17637 into googleapis:main Aug 12, 2026
206 of 207 checks passed
@mutianf
mutianf deleted the hb branch August 12, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants