Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 5 additions & 34 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ jobs:
matrix:
java: [11, 17, 21, 25, 26]
steps:
- name: Get current week within the year
id: date
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
run: echo "::set-output name=week_of_year::$(date +'%W' --utc)"
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
with:
Expand All @@ -79,14 +75,9 @@ jobs:
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be cautious of introducing cache in general. We've seen cache caused other issues such as not using the latest versions before.
How often do we see this issue? Is this issue caused by unstable Maven central?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline that this may cause false positive CIs that code changes in Gax/Auth are not propagated to downstream tests.

- run: java -version
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
id: mvn-cache
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-unified-${{ steps.date.outputs.week_of_year }}
- run: .kokoro/build.sh
if: ${{ needs.bulk-filter.outputs.runnable == 'true' && (needs.bulk-filter.outputs.src == 'true' || needs.bulk-filter.outputs.ci == 'true') }}
env:
Expand All @@ -97,10 +88,6 @@ jobs:
needs: bulk-filter
name: "units (8)"
steps:
- name: Get current week within the year
id: date
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
run: echo "::set-output name=week_of_year::$(date +'%W' --utc)"
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
with:
Expand All @@ -122,12 +109,6 @@ jobs:
java-version: 11
distribution: temurin
cache: maven
- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
id: mvn-cache
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-unified-${{ steps.date.outputs.week_of_year }}
- run: .kokoro/build.sh
if: ${{ needs.bulk-filter.outputs.runnable == 'true' && (needs.bulk-filter.outputs.src == 'true' || needs.bulk-filter.outputs.ci == 'true') }}
shell: bash
Expand Down Expand Up @@ -271,16 +252,14 @@ jobs:
package: ${{ fromJSON(needs.changes.outputs.packages) }}
java: [11, 17, 21, 25, 26]
steps:
- name: Get current week within the year
id: date
run: echo "::set-output name=week_of_year::$(date +'%W' --utc)"
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
persist-credentials: false
- uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 # v4.8.0
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven
- run: .kokoro/build.sh
env:
BUILD_SUBDIR: ${{matrix.package}}
Expand All @@ -296,9 +275,6 @@ jobs:
package: ${{ fromJSON(needs.changes.outputs.packages) }}
java: [8]
steps:
- name: Get current week within the year
id: date
run: echo "::set-output name=week_of_year::$(date +'%W' --utc)"
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
persist-credentials: false
Expand All @@ -308,11 +284,6 @@ jobs:
distribution: temurin
cache: maven
- run: java -version
- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
id: mvn-cache
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-unified-${{ steps.date.outputs.week_of_year }}
- name: Install all modules using Java 11
shell: bash
run: .kokoro/build.sh
Expand Down Expand Up @@ -353,6 +324,7 @@ jobs:
with:
distribution: temurin
java-version: 11
cache: maven
- run: .kokoro/build.sh
env:
BUILD_SUBDIR: ${{matrix.package}}
Expand All @@ -372,6 +344,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: .kokoro/dependencies.sh
env:
BUILD_SUBDIR: ${{matrix.package}}
Expand Down Expand Up @@ -419,6 +392,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -430,9 +404,6 @@ jobs:
if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
runs-on: ubuntu-latest
steps:
- name: Get current week within the year
id: date
run: echo "::set-output name=week_of_year::$(date +'%W' --utc)"
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
persist-credentials: false
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/google-auth-library-java-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -74,6 +75,7 @@ jobs:
with:
distribution: temurin
java-version: 11
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -91,6 +93,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: .kokoro/dependencies.sh

required:
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/java-bigquery-jdbc-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ jobs:
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -81,6 +82,7 @@ jobs:
with:
java-version: 8
distribution: temurin
cache: maven
- name: "Set jvm system property environment variable for surefire plugin (unit tests)"
# Maven surefire plugin (unit tests) allows us to specify JVM to run the tests.
# https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#jvm
Expand All @@ -90,6 +92,7 @@ jobs:
with:
java-version: 17
distribution: temurin
cache: maven
- run: .kokoro/build.sh
env:
JOB_TYPE: test
Expand All @@ -109,6 +112,7 @@ jobs:
with:
distribution: temurin
java-version: 8
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -125,6 +129,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: .kokoro/dependencies.sh
javadoc:
needs: filter
Expand All @@ -138,6 +143,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -155,6 +161,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/java-bigtable-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -73,6 +74,7 @@ jobs:
with:
java-version: 8
distribution: temurin
cache: maven
- name: "Set jvm system property environment variable for surefire plugin (unit tests)"
# Maven surefire plugin (unit tests) allows us to specify JVM to run the tests.
# https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#jvm
Expand All @@ -82,6 +84,7 @@ jobs:
with:
java-version: 17
distribution: temurin
cache: maven
- run: .kokoro/build.sh
env:
JOB_TYPE: test
Expand All @@ -99,6 +102,7 @@ jobs:
with:
distribution: temurin
java-version: 8
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -118,6 +122,7 @@ jobs:
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven
- run: java -version
- run: .kokoro/dependencies.sh
javadoc:
Expand All @@ -132,6 +137,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -149,6 +155,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -167,6 +174,7 @@ jobs:
with:
distribution: temurin
java-version: 11
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/java-bigtable-conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
with:
distribution: zulu
java-version: 11
cache: maven
- uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5
with:
go-version: '>=1.20.2'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/java-cloud-bom-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ jobs:
with:
distribution: zulu
java-version: 11
cache: maven
- run: java -version
- name: Install modules locally
run: mvn install -B -ntp -Pquick-build -DskipTests=true -T 1C
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/java-firestore-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -73,6 +74,7 @@ jobs:
with:
java-version: 8
distribution: temurin
cache: maven
- name: "Set jvm system property environment variable for surefire plugin (unit tests)"
# Maven surefire plugin (unit tests) allows us to specify JVM to run the tests.
# https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#jvm
Expand All @@ -82,6 +84,7 @@ jobs:
with:
java-version: 17
distribution: temurin
cache: maven
- run: .kokoro/build.sh
env:
JOB_TYPE: test
Expand All @@ -99,6 +102,7 @@ jobs:
with:
distribution: temurin
java-version: 8
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -118,6 +122,7 @@ jobs:
with:
distribution: temurin
java-version: ${{matrix.java}}
cache: maven
- run: java -version
- run: .kokoro/dependencies.sh
javadoc:
Expand All @@ -132,6 +137,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -149,6 +155,7 @@ jobs:
with:
distribution: temurin
java-version: 17
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand All @@ -167,6 +174,7 @@ jobs:
with:
distribution: temurin
java-version: 11
cache: maven
- run: java -version
- run: .kokoro/build.sh
env:
Expand Down
Loading
Loading