feat(bigquery-jdbc): add telemetry configuration class - #13710
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the TelemetryConfiguration class and its corresponding builder to manage configuration settings for the BigQuery JDBC driver telemetry client. It also includes a comprehensive suite of unit tests in TelemetryConfigurationTest to verify default values, custom configurations, and correct behavior of the equals and hashCode methods. There are no review comments, and the changes look solid.
logachev
approved these changes
Jul 9, 2026
Neenu1995
added a commit
that referenced
this pull request
Aug 12, 2026
## Summary Introduces the internal `TelemetryConfiguration` class and builder to manage client-side telemetry settings for the BigQuery JDBC driver. This is **PR 3** of the multi-phase client-side telemetry implementation plan. ## Changes Introduced - **`TelemetryConfiguration`**: Immutable configuration class holding upload intervals, batch size thresholds, log source ID, target endpoint, and environment metadata (`DriverEnvironment`). - **`TelemetryConfiguration.Builder`**: Fluent builder pattern for constructing configuration instances. - **`TelemetryConfigurationTest`**: Unit test suite covering default property initialization, custom property overrides, and `equals`/`hashCode` contracts. - **Visibility Scoping**: Restricted all classes, builders, getters, and constants to package-private (`com.google.cloud.bigquery.jdbc.telemetry.v1`) to prevent exposing internal telemetry implementation details outside the driver package. ## Default Configuration Parameters | Parameter | Default Value | Description | | :--- | :--- | :--- | | `enabled` | `true` | Telemetry is enabled by default per open-source telemetry guidelines (`go/telemetry-oss`). | | `logSource` | `-1` | Placeholder until Clearcut log source ID registration is assigned for BigQuery JDBC. | | `endpointUrl` | `https://play.googleapis.com/log` | Default Clearcut HTTPS log ingestion endpoint. | | `uploadIntervalMs` | `300000` (5 mins) | Periodic background flush interval. | | `batchSizeThreshold` | `100` | Maximum buffered events before triggering an immediate flush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the internal
TelemetryConfigurationclass and builder to manage client-side telemetry settings for the BigQuery JDBC driver.This is PR 3 of the multi-phase client-side telemetry implementation plan.
Changes Introduced
TelemetryConfiguration: Immutable configuration class holding upload intervals, batch size thresholds, log source ID, target endpoint, and environment metadata (DriverEnvironment).TelemetryConfiguration.Builder: Fluent builder pattern for constructing configuration instances.TelemetryConfigurationTest: Unit test suite covering default property initialization, custom property overrides, andequals/hashCodecontracts.com.google.cloud.bigquery.jdbc.telemetry.v1) to prevent exposing internal telemetry implementation details outside the driver package.Default Configuration Parameters
enabledtruego/telemetry-oss).logSource-1endpointUrlhttps://play.googleapis.com/loguploadIntervalMs300000(5 mins)batchSizeThreshold100