Skip to content

fix(ci): ignore SNAPSHOT suffix in flatten-plugin check #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 2 commits into from
Jul 2, 2026
Merged

fix(ci): ignore SNAPSHOT suffix in flatten-plugin check #13639

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd014b5
fix(ci): ignore SNAPSHOT suffix in flatten-plugin check
lqiu96 Jul 1, 2026
ba3af18
Update .kokoro/client-library-check.sh
lqiu96 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .kokoro/client-library-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,17 @@ flatten-plugin)
../.kokoro/build.sh
echo "After running ../.kokoro/build.sh"
pushd ${LIBRARY_NAME}
mvn dependency:list -f .flattened-pom.xml -DincludeScope=runtime -Dsort=true \
mvn -B -ntp dependency:list -f .flattened-pom.xml -DincludeScope=runtime -Dsort=true \
| grep '\[INFO] .*:.*:.*:.*:.*' |awk '{print $2}' > .actual-flattened-dependencies-list.txt
echo "Diff from the expected file (${EXPECTED_DEPENDENCIES_LIST}):"
diff "${scriptDir}/${EXPECTED_DEPENDENCIES_LIST}" .actual-flattened-dependencies-list.txt

# Strip -SNAPSHOT for comparison to support release PRs where dependencies are bumped to release versions
sed 's/-SNAPSHOT//g' "${scriptDir}/${EXPECTED_DEPENDENCIES_LIST}" > .expected-stripped.txt
sed 's/-SNAPSHOT//g' .actual-flattened-dependencies-list.txt > .actual-stripped.txt

echo "Diff from the expected file (${EXPECTED_DEPENDENCIES_LIST}) (ignoring -SNAPSHOT):"
diff .expected-stripped.txt .actual-stripped.txt
RETURN_CODE=$?
rm .expected-stripped.txt .actual-stripped.txt
Comment thread
lqiu96 marked this conversation as resolved.
Outdated
if [ "${RETURN_CODE}" == 0 ]; then
echo "No diff."
else
Expand Down
Loading