Skip to content

fix: fallback on VPC #13567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mutianf merged 4 commits into from
Jun 29, 2026
Merged

fix: fallback on VPC #13567

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3df0864
fix: fallback on VPC
mutianf Jun 29, 2026
631ca36
update error message
mutianf Jun 29, 2026
fc5dd88
nit
mutianf Jun 29, 2026
46589ed
nit
mutianf Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...c/main/java/com/google/cloud/bigtable/data/v2/internal/dp/ClassicDirectAccessChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,15 @@ public boolean check(Channel channel) {
}
}

/** Checks if the exception is due to a VPC Service Controls policy violation. */
private boolean isAllowed(StatusRuntimeException e) {

@sushanb sushanb Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add isAllowedFromVPCServiceControls

String description = e.getStatus().getDescription();
String message = e.getMessage();
return (description != null
&& description.contains("Request is prohibited by organization's policy"))

@sushanb sushanb Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you see if this is the authorative string?

I see "request is prohibited by " as well.

|| (message != null && message.contains("Request is prohibited by organization's policy"));
}

/** Executes the underlying RPC and evaluates the eligibility. */
private boolean evaluateEligibility(Channel channel) {
MetadataExtractorInterceptor interceptor = createInterceptor();
Expand All @@ -91,8 +100,13 @@ private boolean evaluateEligibility(Channel channel) {
if (e.getStatus().getCode() != Code.PERMISSION_DENIED) {
throw e;
}
// Failed with permission error, resorting to ALTS check.
isEligible = sidebandData.isAlts();

if (isAllowed(e)) {
LOG.log(Level.WARNING, "DirectPath is blocked by a perimeter policy violation.");
} else {
// Failed with standard permission error, resorting to ALTS check.
isEligible = sidebandData.isAlts();
}
}

if (isEligible) {
Expand Down
Loading