Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pubsub Mockito dependency #1596

Closed
pongad opened this issue Feb 7, 2017 · 4 comments · Fixed by #1741
Closed

remove pubsub Mockito dependency #1596

pongad opened this issue Feb 7, 2017 · 4 comments · Fixed by #1741
Assignees
@pongad
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@pongad
Copy link
Contributor

pongad commented Feb 7, 2017

maybe use easymock instead
@pongad pongad self-assigned this Feb 7, 2017
@pongad pongad mentioned this issue Feb 7, 2017
Merged
@garrettjonesgoogle garrettjonesgoogle added api: pubsub Issues related to the Pub/Sub API. Status: Release Blocking labels Feb 18, 2017
@pongad
Copy link
Contributor Author

pongad commented Mar 6, 2017

@garrettjonesgoogle I just realized that mockito is also used in google-cloud-contrib and google-cloud-spanner. Do we want to allow use to Mockito? Or do we want to rip it out from those too?

@vkedia
Copy link

vkedia commented Mar 6, 2017

Whats the concern with Mockito?

@pongad
Copy link
Contributor Author

pongad commented Mar 6, 2017

Most of the libraries uses Easy Mock. It's probably better if we can use just one instead of two, though I'm not sure if using both is necessarily a bad thing.

@garrettjonesgoogle
Copy link
Member

google-cloud-contrib is a "side artifact", so it doesn't affect google-cloud. I think we should rip it out of google-cloud-spanner.

@pongad is correct, we want to use only one mocking system instead of two.

@pongad pongad mentioned this issue Mar 9, 2017
Merged
pongad added a commit that referenced this issue Mar 9, 2017
@pongad
pubsub: remove Mockito from SubscriberImplTest (#1719)
149ff7a 
Update #1596.
@pongad pongad mentioned this issue Mar 13, 2017
Merged
pongad added a commit that referenced this issue Mar 13, 2017
@pongad
remove Mockito from pubsub (#1741)
e52a0b6 
fixes #1596.
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#304)
ff743d8 
Source-Link: googleapis/synthtool@316ebf5
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#255)
0679ce1 
Source-Link: googleapis/synthtool@316ebf5
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#301)
178d9dd 
Source-Link: googleapis/synthtool@316ebf5
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#486)
9e55379 
Source-Link: googleapis/synthtool@316ebf5
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#428)
c00505a 
Source-Link: googleapis/synthtool@316ebf5
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#895)
e3e6688 
Source-Link: https://github.com/googleapis/synthtool/commit/316ebf5531c4eed734fd325a9631d3249b3d486e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde
github-actions bot pushed a commit that referenced this issue Oct 4, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#816)
5f4d006 
Source-Link: googleapis/synthtool@316ebf5
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Oct 10, 2022
@gcf-owl-bot
chore: [java] stopping auto release (#1596) (#121)
ce8562b 
Source-Link: https://github.com/googleapis/synthtool/commit/316ebf5531c4eed734fd325a9631d3249b3d486e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:086f6916c24f11a1a196ea47f9da39abb4ca8730fcd6e69158fec4834287bcde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pongad pongad

Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove Mockito from pubsub
3 participants
@pongad @garrettjonesgoogle @vkedia