-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test(bigtable): Run conformance tests for bigtable #8658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c304be5
test(bigtable): Run conformance tests for bigtable
bhshkh 177abd3
test(bigtable): Fixing run
bhshkh 5347173
test(bigtable): Removing cd call
bhshkh 3d894dd
test(bigtable): Add Github action for conformance test
bhshkh 074ca5a
test(bigtable): Correcting checkout path
bhshkh 9162182
Revert "test(bigtable): Correcting checkout path"
bhshkh 5d6fbd7
test(bigtable): Running testproxy on multiple Go versions
bhshkh 0da7c9f
Merge branch 'main' into test/bigtable-conformance
bhshkh 101cac8
test(bigtable): Adding comments
bhshkh 4f8068c
Merge branch 'main' into test/bigtable-conformance
bhshkh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Copyright 2023 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # Github action job to test core java library features on | ||
| # downstream client libraries before they are released. | ||
| on: | ||
| push: | ||
| paths: | ||
| - 'bigtable/**' | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| paths: | ||
| - 'bigtable/**' | ||
| name: bigtable_conformance | ||
| jobs: | ||
| bigtable_conformance: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| # Bigtable test proxy can be run on any of these Go versions | ||
| go: [ '1.19', '1.20', '1.21' ] | ||
| folders: ['bigtable'] | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| path: google-cloud-go | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| repository: googleapis/cloud-bigtable-clients-test | ||
| ref: main | ||
| path: cloud-bigtable-clients-test | ||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: ${{ matrix.go }} | ||
| - run: go version | ||
| - run: go install github.com/jstemmer/go-junit-report/v2@latest | ||
| - run: chmod +x ./google-cloud-go/${{ matrix.folders }}/conformance_test.sh | ||
| - run: ./google-cloud-go/${{ matrix.folders }}/conformance_test.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Copyright 2023 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Fail on any error | ||
| set -eo pipefail | ||
|
|
||
| # Display commands being run | ||
| set -x | ||
|
|
||
| ## cd to the parent directory, i.e. the root of the git repo | ||
| cd $(dirname $0)/../.. | ||
|
|
||
| rootDir=$(pwd) | ||
| clientLibHome=$rootDir/google-cloud-go/bigtable | ||
| testProxyHome=$clientLibHome/internal/testproxy | ||
| testProxyPort=9999 | ||
| conformanceTestsHome=$rootDir/cloud-bigtable-clients-test/tests | ||
|
|
||
| sponge_log=$clientLibHome/sponge_log.log | ||
|
|
||
| cd $testProxyHome | ||
| go build | ||
|
|
||
| nohup $testProxyHome/testproxy --port $testProxyPort & | ||
| proxyPID=$! | ||
|
|
||
| # Stop the testproxy | ||
| function cleanup() { | ||
| echo "Cleanup testproxy and move logs" | ||
| kill -9 $proxyPID | ||
| # Takes the kokoro output log (raw stdout) and creates a machine-parseable | ||
| # xUnit XML file. | ||
| cat $sponge_log | | ||
| go-junit-report -set-exit-code >$clientLibHome/sponge_log.xml | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| # Run the conformance tests | ||
| cd $conformanceTestsHome | ||
| # Tests in https://github.com/googleapis/cloud-bigtable-clients-test/tree/main/tests can only be run on go1.20.2 | ||
| go install golang.org/dl/go1.20.2@latest | ||
| go1.20.2 download | ||
| go1.20.2 test -v -proxy_addr=:$testProxyPort | tee -a $sponge_log | ||
bhshkh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| RETURN_CODE=$? | ||
|
|
||
| echo "exiting with ${RETURN_CODE}" | ||
| exit ${RETURN_CODE} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.