Skip to content

refactor(firestore): [PQ] remove index mode#13595

Merged
bhshkh merged 1 commit intogoogleapis:feature/fs-pipeline-queriesfrom
bhshkh:feat/fspq-remove-index-mode
Jan 13, 2026
Merged

refactor(firestore): [PQ] remove index mode#13595
bhshkh merged 1 commit intogoogleapis:feature/fs-pipeline-queriesfrom
bhshkh:feat/fspq-remove-index-mode

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Jan 13, 2026

Index mode has been postponed to GA. removing it.

@bhshkh bhshkh requested review from a team January 13, 2026 21:51
@bhshkh bhshkh requested a review from a team as a code owner January 13, 2026 21:51
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the Firestore API. label Jan 13, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @bhshkh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Firestore client library by removing the WithIndexMode functionality. This change is necessary because the index mode feature, which was previously introduced, has been deferred for release until General Availability, making its current inclusion premature.

Highlights

  • Removal of Index Mode: The WithIndexMode function and its associated documentation comment have been removed from firestore/pipeline.go. This change reflects the decision to postpone the index mode feature until General Availability (GA).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the WithIndexMode function as the feature has been postponed. The change is straightforward. I've left one comment suggesting the removal of potentially related dead code, specifically the IndexMode field in executeSettings and its usages, to maintain code quality.

I am having trouble creating individual review comments. Click here to see my feedback.

firestore/pipeline.go (101-106)

medium

With the removal of WithIndexMode, the IndexMode field on the executeSettings struct and any logic that uses it might now be dead code. To keep the codebase clean, please consider removing these as well if they are no longer used.

@bhshkh bhshkh merged commit 8ea265e into googleapis:feature/fs-pipeline-queries Jan 13, 2026
8 checks passed
@bhshkh bhshkh deleted the feat/fspq-remove-index-mode branch January 13, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant