feat(cloudsecuritycompliance): add new clients#13540
feat(cloudsecuritycompliance): add new clients#13540bhshkh wants to merge 1 commit intogoogleapis:mainfrom
Conversation
PiperOrigin-RevId: 799477610
|
This PR resolves b/441231689 |
Summary of ChangesHello @bhshkh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new Go client for the Cloud Security Compliance API. The changes include the generated client code, examples, and configuration files. My review found a critical issue in the .librarian/state.yaml configuration where the remove_regex patterns appear to be incorrectly configured to remove the newly added client files, which could break the client. Please review this configuration.
| remove_regex: | ||
| - ^internal/generated/snippets/cloudsecuritycompliance/ | ||
| - ^cloudsecuritycompliance/apiv1/[^/]*_client\.go$ | ||
| - ^cloudsecuritycompliance/apiv1/[^/]*_client_example_go123_test\.go$ | ||
| - ^cloudsecuritycompliance/apiv1/[^/]*_client_example_test\.go$ | ||
| - ^cloudsecuritycompliance/apiv1/auxiliary\.go$ | ||
| - ^cloudsecuritycompliance/apiv1/auxiliary_go123\.go$ | ||
| - ^cloudsecuritycompliance/apiv1/doc\.go$ | ||
| - ^cloudsecuritycompliance/apiv1/gapic_metadata\.json$ | ||
| - ^cloudsecuritycompliance/apiv1/helpers\.go$ | ||
| - ^cloudsecuritycompliance/apiv1/\.repo-metadata\.json$ | ||
| - ^cloudsecuritycompliance/apiv1/cloudsecuritycompliancepb/.*$ |
There was a problem hiding this comment.
The remove_regex patterns seem to be configured to remove most of the files being added in this pull request for the cloudsecuritycompliance client. For example, ^cloudsecuritycompliance/apiv1/[^/]*_client\.go$ will match and remove all the newly added client files like audit_client.go, and ^internal/generated/snippets/cloudsecuritycompliance/ will remove all snippet files. This seems incorrect if the goal is to add this new client. Please verify if these remove_regex entries are intended. If the files are meant to be kept, these regexes should be removed to prevent the new client files from being deleted by any automation.
|
Created #13660 |
1 participant
PiperOrigin-RevId: 799477610