Skip to content

chore: librarian release pull request: 20251113T033322Z#13349

Closed
cpriti-os wants to merge 1 commit intomainfrom
librarian-20251113T033322Z
Closed

chore: librarian release pull request: 20251113T033322Z#13349
cpriti-os wants to merge 1 commit intomainfrom
librarian-20251113T033322Z

Conversation

@cpriti-os
Copy link
Copy Markdown
Contributor

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.

Librarian Version: v1.0.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:c4bb601f466f857040028f81c47ecf808034fcf8463166320f80be761653d167

storage: 1.58.0

1.58.0 (2025-11-13)

Features

  • make return_partial_success and unreachable fields public for list Bucket (PiperOrigin-RevId: 828488192) (93ca68d5)

Bug Fixes

Documentation

  • updates to docs and docs formatting (PiperOrigin-RevId: 828488192) (93ca68d5)

@cpriti-os cpriti-os requested review from a team November 13, 2025 03:33
@cpriti-os cpriti-os requested a review from a team as a code owner November 13, 2025 03:33
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @cpriti-os, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated release generated by the Librarian CLI, designed to update the storage module to version 1.58.0. Merging this PR will trigger the official release process, incorporating new features such as public fields for bucket listing, a critical bug fix related to bound tokens, and general documentation enhancements.

Highlights

  • Storage Module Release: This pull request initiates the release of the storage module, updating its version from 1.57.1 to 1.58.0.
  • New Features: The storage module now exposes return_partial_success and unreachable fields as public for the list Bucket operation.
  • Bug Fix: A bug fix has been included, adding an environment variable to allow disabling bound tokens.
  • Documentation Updates: Various documentation updates and formatting improvements have been applied to the storage module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated release PR for the storage module, bumping its version to 1.58.0. The changes include updating version numbers in configuration files, source code, and adding a new entry to the changelog. The changes appear to be correct for a release. I have one suggestion to improve the clarity and formatting of the generated changelog entry to make it more user-friendly.

Comment thread storage/CHANGES.md
Comment on lines +6 to +16
### Features

* make return_partial_success and unreachable fields public for list Bucket ([93ca68d](https://github.com/googleapis/google-cloud-go/commit/93ca68d54b6d213f22e0d67ae01d135cf26d37c6))

### Bug Fixes

* add env var to allow disabling bound token (#13236) ([cdaf6a6](https://github.com/googleapis/google-cloud-go/commit/cdaf6a6da006a19db932a74885ea3722b4e42311))

### Documentation

* updates to docs and docs formatting ([93ca68d](https://github.com/googleapis/google-cloud-go/commit/93ca68d54b6d213f22e0d67ae01d135cf26d37c6))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog entries could be improved for clarity and consistency for end-users.

  • The descriptions appear to be taken directly from commit messages. For user-facing release notes, it's better to rephrase them as complete sentences starting with a capital letter and using code formatting for identifiers.
  • The documentation update for commit 93ca68d is also part of the feature in the same commit. Listing it separately under "Documentation" with a generic message like "updates to docs and docs formatting" is redundant and not very informative. It would be better to remove this entry, as documentation for a feature is usually implied.

Here is a suggested revision for better readability:

### Features

*   Make `return_partial_success` and `unreachable` fields public for `listBucket` calls ([93ca68d](https://github.com/googleapis/google-cloud-go/commit/93ca68d54b6d213f22e0d67ae01d135cf26d37c6)).

### Bug Fixes

*   Add an environment variable to allow disabling bound tokens (#13236) ([cdaf6a6](https://github.com/googleapis/google-cloud-go/commit/cdaf6a6da006a19db932a74885ea3722b4e42311)).

@cpriti-os cpriti-os closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant