Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .librarian/state.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2384,6 +2384,29 @@ libraries:
release_exclude_paths:
- internal/generated/snippets/gkemulticloud/
tag_format: '{id}/v{version}'
- id: gkerecommender
version: 0.0.0
last_generated_commit: c288189b43c016dd3cf1ec73ce3cadee8b732f07
apis:
- path: google/cloud/gkerecommender/v1
service_config: gkerecommender_v1.yaml
source_roots:
- gkerecommender
- internal/generated/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is incorrect. I don't know why it's here - I'm looking into it.

- internal/generated/snippets/gkerecommender
preserve_regex: []
remove_regex:
- ^internal/generated/snippets/gkerecommender/
- ^apiv1/[^/]*_client\.go$
- ^apiv1/[^/]*_client_example_go123_test\.go$
- ^apiv1/[^/]*_client_example_test\.go$
- ^apiv1/auxiliary\.go$
- ^apiv1/auxiliary_go123\.go$
- ^apiv1/doc\.go$
- ^apiv1/gapic_metadata\.json$
- ^apiv1/helpers\.go$
- ^apiv1/gkerecommenderpb/.*$
Comment on lines +2398 to +2408
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The remove_regex configuration for the new gkerecommender module appears to be overly aggressive and seems configured to remove most of the essential generated files for the client. This includes the client implementation, example files, helper files, and protobuf-generated code.

For example:

  • ^apiv1/[^/]*_client\.go$ will match and remove apiv1/gke_inference_quickstart_client.go.
  • ^apiv1/gkerecommenderpb/.*$ will match and remove files under apiv1/gkerecommenderpb/, such as gkerecommender_grpc.pb.go.

This would leave the module in a broken state, making the client unusable. This configuration was likely copied from another module's settings without being correctly adapted for gkerecommender. Please review these regular expressions and adjust them to ensure that only files not intended for the final module are removed.

Copy link
Copy Markdown
Member Author

@quartzmo quartzmo Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a normal step in regeneration, so I believe it is the correct configuration.

tag_format: '{id}/v{version}'
- id: grafeas
version: 0.3.17
last_generated_commit: 4591295cdf3e25890919115dde0e546c94046e2c
Expand Down
1 change: 1 addition & 0 deletions gkerecommender/CHANGES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Changes
55 changes: 55 additions & 0 deletions gkerecommender/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# GKE Recommender API

[![Go Reference](https://pkg.go.dev/badge/cloud.google.com/go/gkerecommender.svg)](https://pkg.go.dev/cloud.google.com/go/gkerecommender)

Go Client Library for GKE Recommender API.

## Install

```bash
go get cloud.google.com/go/gkerecommender
```

## Stability

The stability of this module is indicated by SemVer.

However, a `v1+` module may have breaking changes in two scenarios:

* Packages with `alpha` or `beta` in the import path
* The GoDoc has an explicit stability disclaimer (for example, for an experimental feature).

### Which package to use?

Generated client library surfaces can be found in packages who's import path
ends in `.../apivXXX`. The `XXX` could be something like `1` or `2` in the case
of a stable service backend or may be like `1beta2` or `2beta` in the case of a
more experimental service backend. Because of this fact, a given module can have
multiple clients for different service backends. In these cases it is generally
recommend to use clients with stable service backends, with import suffixes like
`apiv1`, unless you need to use features that are only present in a beta backend
or there is not yet a stable backend available.

## Google Cloud Samples

To browse ready to use code samples check [Google Cloud Samples](https://cloud.google.com/docs/samples?l=go).

## Go Version Support

See the [Go Versions Supported](https://github.com/googleapis/google-cloud-go#go-versions-supported)
section in the root directory's README.

## Authorization

See the [Authorization](https://github.com/googleapis/google-cloud-go#authorization)
section in the root directory's README.

## Contributing

Contributions are welcome. Please, see the [CONTRIBUTING](https://github.com/GoogleCloudPlatform/google-cloud-go/blob/main/CONTRIBUTING.md)
document for details.

Please note that this project is released with a Contributor Code of Conduct.
By participating in this project you agree to abide by its terms. See
[Contributor Code of Conduct](https://github.com/GoogleCloudPlatform/google-cloud-go/blob/main/CONTRIBUTING.md#contributor-code-of-conduct)
for more information.
116 changes: 116 additions & 0 deletions gkerecommender/apiv1/auxiliary.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 38 additions & 0 deletions gkerecommender/apiv1/auxiliary_go123.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

85 changes: 85 additions & 0 deletions gkerecommender/apiv1/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading