Skip to content

fix(storage): add env var to allow disabling bound token #13236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tritone merged 2 commits into from
Oct 30, 2025
Merged

fix(storage): add env var to allow disabling bound token #13236

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e67c5f
fix(storage): add env var to allow disabling bound token
rockspore Oct 27, 2025
d7f0daf
change env var name
rockspore Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions storage/grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"io"
"log"
"os"
"strconv"
"sync"

"cloud.google.com/go/iam/apiv1/iampb"
Expand Down Expand Up @@ -101,8 +102,10 @@ func defaultGRPCOptions() []option.ClientOption {
defaults = append(defaults,
internaloption.AllowNonDefaultServiceAccount(true),
internaloption.EnableDirectPath(true),
internaloption.EnableDirectPathXds(),
internaloption.AllowHardBoundTokens("ALTS"))
internaloption.EnableDirectPathXds())
if disableBoundToken, _ := strconv.ParseBool(os.Getenv("GCS_DISABLE_DIRECTPATH_BOUND_TOKEN")); !disableBoundToken {
Comment thread
tritone marked this conversation as resolved.
Outdated
defaults = append(defaults, internaloption.AllowHardBoundTokens("ALTS"))
}
Comment thread
tritone marked this conversation as resolved.
Outdated
}

return defaults
Expand Down
Loading