chore(gkerecommender): Next prototype of running configure for gkerecommender#13213
chore(gkerecommender): Next prototype of running configure for gkerecommender#13213jskeet wants to merge 5 commits intogoogleapis:mainfrom
Conversation
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
jskeet
added
the
do not merge
Summary of ChangesHello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a prototype for configuring and integrating the new GKE Recommender API Go client library into the project. It sets up the necessary configuration for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Go client library for the GKE Recommender API (gkerecommender). The changes include the generated client code, example snippets, and updates to the repository's configuration files to integrate the new module. While most of the changes appear to be standard for adding a new library, there is a critical configuration issue in .librarian/state.yaml that needs to be addressed. The remove_regex patterns are set to delete the essential client files that are being added, which would result in a broken library.
| - ^internal/generated/snippets/gkerecommender/ | ||
| - ^apiv1/[^/]*_client\.go$ | ||
| - ^apiv1/[^/]*_client_example_go123_test\.go$ | ||
| - ^apiv1/[^/]*_client_example_test\.go$ | ||
| - ^apiv1/auxiliary\.go$ | ||
| - ^apiv1/auxiliary_go123\.go$ | ||
| - ^apiv1/doc\.go$ | ||
| - ^apiv1/gapic_metadata\.json$ | ||
| - ^apiv1/helpers\.go$ | ||
| - ^apiv1/gkerecommenderpb/.*$ |
There was a problem hiding this comment.
This remove_regex configuration appears to be incorrect. It's configured to remove all the essential generated client files and snippets that are being added in this pull request. This will likely result in a broken or incomplete client library.
For example:
^internal/generated/snippets/gkerecommender/will remove the generated snippets.^apiv1/[^/]*_client\\.go$will removegke_inference_quickstart_client.go.
These files are necessary for the client library to function. Please remove these regular expressions to ensure the files are preserved.
Summary of ChangesHello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Go module for the GKE Recommender API, gkerecommender. The changes include the generated client library code, example snippets, and module files (go.mod, go.sum). Configuration files for the repository's tooling (.librarian/config.yaml, .librarian/state.yaml) and the Go workspace (go.work) have also been updated to incorporate this new module. My review focuses on the configuration changes, as most of the code is auto-generated. I've found a critical issue in the remove_regex configuration for the new library which would likely cause the build to fail by removing all the generated source files.
This is now fixed in the template in librariangen.
|
@quartzmo I think this is a reasonable pausing point. vet now passes, which is a start. Will create a new PR for the container implementation. |
jskeet
changed the title
quartzmo
changed the title
|
Closing in favor of #13220 |
2 participants
Notes:
So basically our initial playbook would be:
librarian generate -api=google/cloud/abc/v1 -library=abc(cd abc && go mod tidy)go work use ./abc(The second and third steps would only be necessary for a new library as opposed to a new API within an existing library.)