Skip to content

fix(internal/gapicgen): handle deleted files in git history#13200

Merged
quartzmo merged 3 commits intogoogleapis:mainfrom
quartzmo:genbot-fix-git-history
Oct 21, 2025
Merged

fix(internal/gapicgen): handle deleted files in git history#13200
quartzmo merged 3 commits intogoogleapis:mainfrom
quartzmo:genbot-fix-git-history

Conversation

@quartzmo
Copy link
Copy Markdown
Member

The genbot would previously crash if it encountered a commit that deleted a proto file. This was because it was trying to read the file from the current filesystem, where it no longer existed.

This change updates the genbot to read the file content from the historical commit directly, making the process resilient to file deletions and renames.i

refs: #13188
refs: #13189

The genbot would previously crash if it encountered a commit that
deleted a proto file. This was because it was trying to read the
file from the current filesystem, where it no longer existed.

This change updates the genbot to read the file content from the
historical commit directly, making the process resilient to file
deletions and renames.i

refs: googleapis#13188
refs: googleapis#13189
@quartzmo quartzmo requested a review from a team October 21, 2025 17:22
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @quartzmo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the genbot's ability to process Git history by addressing a critical vulnerability where it would fail upon encountering deleted or renamed proto files. By introducing a method to retrieve file content directly from historical commits, the bot can now accurately analyze changes without relying on the current filesystem state, thereby ensuring more reliable and resilient code generation workflows.

Highlights

  • Genbot Crash Fix: Resolved an issue where the genbot would crash when encountering deleted proto files in Git history.
  • Historical Content Retrieval: Implemented a mechanism to read file content directly from specific historical Git commits.
  • Resilience Improvement: Enhanced the genbot's robustness to handle file deletions and renames gracefully.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses a crash that occurred when the genbot processed a commit involving a deleted proto file. The approach of reading file content from the git history is sound, and the refactoring of goPkg into parseGoPkg improves code modularity. I have one suggestion to enhance the error logging for better debuggability. Overall, this is a solid improvement.

Comment thread internal/gapicgen/generator/generator.go
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
bhshkh
bhshkh previously approved these changes Oct 21, 2025
@bhshkh
Copy link
Copy Markdown
Contributor

bhshkh commented Oct 21, 2025

Please resolve vet failures.

@quartzmo
Copy link
Copy Markdown
Member Author

@bhshkh Sorry, vet was broken by the Gemini reviewer's suggested commit! Fixed now.

@quartzmo quartzmo merged commit 7a85df3 into googleapis:main Oct 21, 2025
9 checks passed
@quartzmo quartzmo deleted the genbot-fix-git-history branch October 21, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants