Skip to content

refactor(firestore): Modify integration test to run on enterprise db #13195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhshkh wants to merge 1 commit into from
Closed

refactor(firestore): Modify integration test to run on enterprise db #13195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 44 additions & 18 deletions firestore/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,29 @@ import (
"google.golang.org/protobuf/types/known/structpb"
)

func TestMain(m *testing.M) {
databaseIDs := []string{DefaultDatabaseID}
databasesStr, ok := os.LookupEnv(envDatabases)
if ok {
databaseIDs = append(databaseIDs, strings.Split(databasesStr, ",")...)
}
type firestoreEdition int

const (
editionStandard firestoreEdition = iota // 0
editionEnterprise // 1
)

const (
envProjID = "GCLOUD_TESTS_GOLANG_FIRESTORE_PROJECT_ID"
envPrivateKey = "GCLOUD_TESTS_GOLANG_FIRESTORE_KEY"
envDatabases = "GCLOUD_TESTS_GOLANG_FIRESTORE_DATABASES"
envEnterpriseDatabases = "GCLOUD_TESTS_GOLANG_FIRESTORE_ENTERPRISE_DATABASES"
envEmulator = "FIRESTORE_EMULATOR_HOST"
indexBuilding = "index is currently building"
databaseIDKey = "databaseID"
firestoreEditionKey = "edition"
)

func TestMain(m *testing.M) {
testParams = make(map[string]interface{})
for _, databaseID := range databaseIDs {
testParams["databaseID"] = databaseID
for databaseID, edition := range parseDatabases() {
testParams[databaseIDKey] = databaseID
testParams[firestoreEditionKey] = edition
initIntegrationTest()
status := m.Run()
if status != 0 {
Expand All @@ -68,13 +81,26 @@ func TestMain(m *testing.M) {
os.Exit(0)
}

const (
envProjID = "GCLOUD_TESTS_GOLANG_FIRESTORE_PROJECT_ID"
envPrivateKey = "GCLOUD_TESTS_GOLANG_FIRESTORE_KEY"
envDatabases = "GCLOUD_TESTS_GOLANG_FIRESTORE_DATABASES"
envEmulator = "FIRESTORE_EMULATOR_HOST"
indexBuilding = "index is currently building"
)
func parseDatabases() map[string]firestoreEdition {
databases := map[string]firestoreEdition{
DefaultDatabaseID: editionStandard,
}

databasesStr, ok := os.LookupEnv(envDatabases)
if ok {
for _, databaseID := range strings.Split(databasesStr, ",") {
databases[databaseID] = editionStandard
}
}

databasesStr, ok = os.LookupEnv(envEnterpriseDatabases)
if ok {
for _, databaseID := range strings.Split(databasesStr, ",") {
databases[databaseID] = editionEnterprise
}
}
return databases
}

var (
iClient *Client
Expand All @@ -88,7 +114,7 @@ var (
)

func initIntegrationTest() {
databaseID := testParams["databaseID"].(string)
databaseID := testParams[databaseIDKey].(string)
log.Printf("Setting up tests to run on databaseID: %q\n", databaseID)
flag.Parse() // needed for testing.Short()
if testing.Short() {
Expand Down Expand Up @@ -2730,12 +2756,12 @@ func TestIntegration_NewClientWithDatabase(t *testing.T) {
}{
{
desc: "Success",
dbName: testParams["databaseID"].(string),
dbName: testParams[databaseIDKey].(string),
wantErr: false,
},
{
desc: "Error from NewClient bubbled to NewClientWithDatabase",
dbName: testParams["databaseID"].(string),
dbName: testParams[databaseIDKey].(string),
wantErr: true,
opt: []option.ClientOption{option.WithCredentialsFile("non existent filepath")},
},
Expand Down
Loading