chore: migrate 8 modules (cloudbuild - vmmigration) to librarian#13149
Merged
quartzmo merged 5 commits intogoogleapis:mainfrom Oct 15, 2025
Merged
chore: migrate 8 modules (cloudbuild - vmmigration) to librarian#13149quartzmo merged 5 commits intogoogleapis:mainfrom
quartzmo merged 5 commits intogoogleapis:mainfrom
Conversation
Contributor
jskeet
commented
Oct 15, 2025
jskeet
commented
- cloudbuild
- datacatalog
- datastream
- dialogflow
- iam
- monitoring
- run
- vmmigration
Contributor
Author
|
Running |
quartzmo
reviewed
Oct 15, 2025
| @@ -172,11 +130,6 @@ deep-preserve-regex: | |||
| - /storage/internal/apiv2/metadata.go | |||
| - /containeranalysis/apiv1beta1/grafeas/.* | |||
| # Must preserve these even though they aren't generated anymore | |||
Member
There was a problem hiding this comment.
In migrating the 5 modules below to Librarian, are we breaking in any way the intent in the comment above to "preserve these even though they aren't generated anymore"?
Contributor
Author
There was a problem hiding this comment.
No - they're explicitly preserved in state.yaml. And the comment itself is still valid for compute/apiv1/smoke_test.go. (But we should prune orphan comments at some point - I've already seen one.)
quartzmo
changed the title
quartzmo
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.