Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(spanner): use passthrough with emulator endpoint #10947

Merged
merged 2 commits into from
Oct 3, 2024
Merged

perf(spanner): use passthrough with emulator endpoint #10947

merged 2 commits into from
Oct 3, 2024

Conversation

rahul2393
Copy link
Contributor

Fixes: #10927

@rahul2393 rahul2393 requested review from a team as code owners October 3, 2024 10:19
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Oct 3, 2024
@rahul2393 rahul2393 enabled auto-merge (squash) October 3, 2024 10:19
olavloite
olavloite approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side note: Is this something that also affects our tests using the mocked Spanner server? That also just uses a plain-text localhost connection.

@rahul2393 rahul2393 merged commit 9e964dd into main Oct 3, 2024
9 checks passed
@rahul2393 rahul2393 deleted the fix-spanner-emulator branch October 3, 2024 11:43
@release-please release-please bot mentioned this pull request Oct 3, 2024
Merged
@bhshkh bhshkh mentioned this pull request Oct 8, 2024
Open
@bhshkh bhshkh added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 8, 2024
This was referenced Oct 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@quartzmo quartzmo Awaiting requested review from quartzmo

@harshachinta harshachinta Awaiting requested review from harshachinta

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auth: Significant performance degradation with new authentication library in Spanner client (100x slower)
3 participants
@rahul2393 @olavloite @bhshkh