feat(pubsub): allow trace extraction from protobuf message #10827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export the function NewMessageCarrierFromPB which, given a protobuf PubsubMessage, returns a TextMapCarrier which can be used to extract trace contexts. This allows it to be used in e.g. HTTP push endpoints.
This was referenced Sep 5, 2024
hongalex
approved these changes
Sep 6, 2024
kokoro-team
removed
the
kokoro:run
radhus
added a commit
to einride/cloudrunner-go
that referenced
this pull request
Sep 10, 2024
Pass a context that contains trace information extracted from the
incoming message, allowing traces to span from publishers over to
subscribers.
In order for publishers to include tracing information, the pubsub
client should be created with:
```go
client, err := pubsub.NewClientWithConfig(
ctx,
cloudrunner.Runtime(ctx).ProjectID,
&pubsub.ClientConfig{
EnableOpenTelemetryTracing: true,
},
```
Depends on googleapis/google-cloud-go#10827
which is included in
[v1.43.0](https://github.com/googleapis/google-cloud-go/releases/tag/pubsub%2Fv1.43.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the function NewMessageCarrierFromPB which, given a protobuf PubsubMessage, returns a TextMapCarrier which can be used to extract trace contexts.
This allows it to be used in e.g. HTTP push endpoints.
Fixes #10828