Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute/apiv1: TestCapitalLetter failed #5988

Closed
flaky-bot bot opened this issue May 4, 2022 · 5 comments · Fixed by #5992, #6292, #6307 or #6908
Closed

compute/apiv1: TestCapitalLetter failed #5988

flaky-bot bot opened this issue May 4, 2022 · 5 comments · Fixed by #5992, #6292, #6307 or #6908
Assignees
@codyoss
Labels
api: compute Issues related to the Compute Engine API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 4, 2022

Note: #4741 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 3972c38
buildURL: Build Status, Sponge
status: failed

Test output
    smoke_test.go:490: retry failed with context deadline exceeded; last error: googleapi: Error 404: The resource 'projects/dulcet-port-762/global/firewalls/gogapic-20220504-28369169939933-0001' was not found
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 4, 2022
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label May 4, 2022
codyoss added a commit to codyoss/google-cloud-go that referenced this issue May 4, 2022
@codyoss
test(comptue): increase time for flaky test
36a77cf 
Fixes: googleapis#5988
@codyoss codyoss mentioned this issue May 4, 2022
Merged
codyoss added a commit that referenced this issue May 4, 2022
@codyoss
test(compute): increase time for flaky test (#5992)
cebbd5e 
Fixes: #5988
@flaky-bot flaky-bot bot reopened this May 5, 2022
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label May 5, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented May 5, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

commit: 9a60d95
buildURL: Build Status, Sponge
status: failed

Test output
    smoke_test.go:490: retry failed with context deadline exceeded; last error: googleapi: Error 404: The resource 'projects/dulcet-port-762/global/firewalls/gogapic-20220505-61993224015989-0001' was not found

@codyoss codyoss added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 5, 2022
@codyoss codyoss self-assigned this Jun 30, 2022
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Jun 30, 2022
@codyoss
test(compute): wait on operations and don't retry them
ed20dcc 
Operations should be waited on and not just created. This was causing
tests to fail because the operation was finishing silently and then
subsquent delete operations could not find the resulting instance
that had already been deleted.

Fixes: googleapis#5988
@codyoss codyoss mentioned this issue Jun 30, 2022
Merged
codyoss added a commit that referenced this issue Jun 30, 2022
@codyoss
test(compute): wait on operations and don't retry them (#6292)
eed822d 
Operations should be waited on and not just created. This was causing
tests to fail because the operation was finishing silently and then
subsquent delete operations could not find the resulting instance
that had already been deleted.

Fixes: #5988
@flaky-bot flaky-bot bot reopened this Jul 1, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 1, 2022

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

commit: c0a0c20
buildURL: Build Status, Sponge
status: failed

Test output
    smoke_test.go:484: googleapi: Error 400: The resource 'projects/dulcet-port-762/global/firewalls/gogapic-20220701-6971834107891-0001' is not ready
panic: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/testing/testing.go:1072 +0x46a
/usr/local/go/src/testing/testing.go:1075 +0x636
/usr/local/go/src/runtime/panic.go:975 +0x47a
/tmpfs/src/google-cloud-go/compute/apiv1/operations.go:51 +0x7f
/tmpfs/src/google-cloud-go/compute/apiv1/smoke_test.go:486 +0x30d
/tmpfs/src/google-cloud-go/compute/apiv1/smoke_test.go:500 +0xd06
/usr/local/go/src/testing/testing.go:1123 +0x203
/usr/local/go/src/testing/testing.go:1168 +0x5bc

codyoss added a commit to codyoss/google-cloud-go that referenced this issue Jul 6, 2022
@codyoss
test(compute): fix flake
f02a79f 
Add retry around the creation of the operation as even though it
is fetched right away this does not mean it can be delted yet.

Fixes: googleapis#5988
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Jul 6, 2022
@codyoss
test(compute): add retry
49b4321 
Just because a firewall has been fetched does not mean it can be
deleted yet. Retry the delete operation as the resource is not
always full allocated enough to delete it right away.

Fixes: googleapis#5988
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Jul 6, 2022
@codyoss
test(compute): fix flake
0f958f5 
Add retry around the creation of the operation as even though it
is fetched right away this does not mean it can be delted yet.

Fixes: googleapis#5988
@codyoss codyoss mentioned this issue Jul 6, 2022
Merged
codyoss added a commit that referenced this issue Jul 6, 2022
@codyoss
test(compute): fix flake (#6307)
8d455a5 
Add retry around the creation of the operation as even though it
is fetched right away this does not mean it can be delted yet.

Fixes: #5988
@flaky-bot flaky-bot bot reopened this Jul 11, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 11, 2022

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

commit: 5ea92cf
buildURL: Build Status, Sponge
status: failed

Test output
    retry.go:44: FAILED after 20 attempts:
        smoke_test.go:486: googleapi: Error 404: The resource 'projects/dulcet-port-762/global/firewalls/gogapic-20220711-29510602544337-0001' was not found
    smoke_test.go:490:

@codyoss codyoss assigned rsamborski and unassigned codyoss Aug 1, 2022
@rsamborski
Copy link
Member

@FrodoTheTrue PTAL

@rsamborski rsamborski assigned rsamborski and unassigned FrodoTheTrue Oct 3, 2022
@rsamborski rsamborski assigned codyoss and unassigned rsamborski Oct 20, 2022
@rsamborski
Copy link
Member

rsamborski commented Oct 20, 2022 •
edited
Loading

@codyoss reassigning back to you as this looks like a flaky smoke test. Please decide if you'd like to turn it off or address differently.

codyoss added a commit to codyoss/google-cloud-go that referenced this issue Oct 21, 2022
@codyoss
test(compute): remove TestCapitalLetter
7d4006f 
This test has been flaky for a long time. If we want something like
this test in the future I think it needs to be re-structured to be
successful. For now we will remove it as it is not providing value
as is and since writing there are now many tests in our samples that
should cover these types of use-cases.

Fixes: googleapis#5988
@codyoss codyoss mentioned this issue Oct 21, 2022
Merged
codyoss added a commit that referenced this issue Oct 24, 2022
@codyoss
test(compute): remove TestCapitalLetter (#6908)
c6b704a 
This test has been flaky for a long time. If we want something like this test in the future I think it needs to be re-structured to be successful. For now we will remove it as it is not providing value as is and since writing there are now many tests in our samples that should cover these types of use-cases.

Fixes: #5988
kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this issue Oct 25, 2022
@codyoss @kimihrr
test(compute): remove TestCapitalLetter (googleapis#6908)
b8bfbda 
This test has been flaky for a long time. If we want something like this test in the future I think it needs to be re-structured to be successful. For now we will remove it as it is not providing value as is and since writing there are now many tests in our samples that should cover these types of use-cases.

Fixes: googleapis#5988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
api: compute Issues related to the Compute Engine API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@rsamborski @codyoss @FrodoTheTrue