-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: investigate and document Proto v2 API usage #1815
Comments
There should be relatively little public affect to using the newer API. Most of the protobuf usage is within the internal implementation, the only place places where the old API leaks to the exported API are in the following two packages: where the older To upgrade to using the new API, I recommend doing the following:
|
What is the roadmap for this? Old generated versions of |
This will make go-genproto messages make use of the new protoreflect features and remove XXX fields. From my testing I believe this should be safe. The subsequent regen PR/CL will need some manual tweaks because of diffs in the mod files. Updates: #1815 Change-Id: Ic9e0029c37bb7557245c68ef37dd1ddca37cbe66 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/56412 Reviewed-by: kokoro <[email protected]> Reviewed-by: Noah Dietz <[email protected]> Reviewed-by: Chris Broadfoot <[email protected]> Reviewed-by: Tyler Bui-Palsulich <[email protected]>
http://google.golang.org/protobuf is the v2 version of https://github.com/golang/protobuf.
We should investigate how we can/should use it for cloud.google.com/go (among other Go repos).
We might also want to see if there is a way clients could use v2, even if our repos can't directly switch to v2.
We should also publish something in the root README saying what the plan is.
The text was updated successfully, but these errors were encountered: