First prototype of a console formatter for Google Cloud Logging #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of this commit is a sample app, which can probably be removed later. There's just one perfunctory test, and a lot more work to do thinking about exactly how we want the JSON to look - but it's a start. (There's no hurry here, as we probably don't want to release anything before the ConsoleFormatter API goes GA anyway.)
google-cla
bot
added
the
cla: yes
Closed
4 tasks
|
I'll take a look later today. It does look pretty good at first glance. |
amanda-tarafa
approved these changes
Jul 23, 2020
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <Description>ConsoleFormatter for Google Cloud Logging.</Description> | ||
| <PackageTags>Logging;Stackdriver;ILogger;Console;Google;Cloud</PackageTags> |
There was a problem hiding this comment.
Remove Stackdriver? Granted people might still be using that for looking libs up.
There was a problem hiding this comment.
Yup, that was the only reason for including it. We can remove all the Stackdriver tags from all packages in a couple of years when they're no longer useful at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of this commit is a sample app, which can probably be removed later.
There's just one perfunctory test, and a lot more work to do thinking about exactly how we want the JSON to look - but it's a start.
(There's no hurry here, as we probably don't want to release anything before the ConsoleFormatter API goes GA anyway.)
Screenshots of a before/after:
Vanilla console logging:
With the console formatter: