-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(pubsub): start the publish span as a root span #13285
Conversation
Since this was added recently, it won't be available in the oldest deps. https://github.com/open-telemetry/opentelemetry-cpp/blame/main/api/include/opentelemetry/trace/span_metadata.h#L24. Gonna do something hacky and just use the string until we upgrade Opened #13287 |
2c9462b
to
f03634f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13285 +/- ##
==========================================
- Coverage 93.05% 93.05% -0.01%
==========================================
Files 2137 2137
Lines 186491 186517 +26
==========================================
+ Hits 173548 173564 +16
- Misses 12943 12953 +10 ☔ View full report in Codecov by Sentry. |
Now that open-telemetry/opentelemetry-cpp#2427 is in we can start an async span as a root span
This change is