Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(pubsub): start the publish span as a root span #13285

Merged
merged 8 commits into from
Dec 19, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Dec 13, 2023

Now that open-telemetry/opentelemetry-cpp#2427 is in we can start an async span as a root span


This change is Reviewable

@alevenberg
Copy link
Member Author

Since this was added recently, it won't be available in the oldest deps. https://github.com/open-telemetry/opentelemetry-cpp/blame/main/api/include/opentelemetry/trace/span_metadata.h#L24. Gonna do something hacky and just use the string until we upgrade

Opened #13287

@alevenberg alevenberg marked this pull request as ready for review December 13, 2023 18:20
@alevenberg alevenberg requested a review from a team as a code owner December 13, 2023 18:20
@alevenberg alevenberg enabled auto-merge (squash) December 13, 2023 19:11
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4b0970) 93.05% compared to head (f02ead8) 93.05%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13285      +/-   ##
==========================================
- Coverage   93.05%   93.05%   -0.01%     
==========================================
  Files        2137     2137              
  Lines      186491   186517      +26     
==========================================
+ Hits       173548   173564      +16     
- Misses      12943    12953      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg requested a review from dbolduc December 14, 2023 20:24
google/cloud/testing_util/opentelemetry_matchers.h Outdated Show resolved Hide resolved
google/cloud/testing_util/opentelemetry_matchers.h Outdated Show resolved Hide resolved
google/cloud/pubsub/internal/tracing_batch_sink_test.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/internal/tracing_batch_sink.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/internal/tracing_batch_sink_test.cc Outdated Show resolved Hide resolved
@dbolduc dbolduc disabled auto-merge December 14, 2023 20:32
@alevenberg alevenberg enabled auto-merge (squash) December 19, 2023 20:52
@alevenberg alevenberg merged commit 916fe8f into googleapis:main Dec 19, 2023
59 checks passed
@alevenberg alevenberg deleted the start-root-span branch December 19, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants