Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): MatchGlob for ListObjects() #12840

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 6, 2023

Support globs to filter object listing operations.

Fixes #1227


This change is Reviewable

Support globs to filter object listing operations.
@coryan coryan temporarily deployed to internal October 6, 2023 20:38 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 6, 2023
@coryan coryan marked this pull request as ready for review October 6, 2023 21:16
@coryan coryan requested a review from a team as a code owner October 6, 2023 21:16
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ebc394a) 93.54% compared to head (f6defc2) 93.54%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12840      +/-   ##
==========================================
- Coverage   93.54%   93.54%   -0.01%     
==========================================
  Files        2074     2074              
  Lines      180348   180370      +22     
==========================================
+ Hits       168715   168735      +20     
- Misses      11633    11635       +2     
Files Coverage Δ
google/cloud/storage/client.h 99.84% <ø> (ø)
...oud/storage/internal/grpc/object_request_parser.cc 97.79% <100.00%> (+<0.01%) ⬆️
...torage/internal/grpc/object_request_parser_test.cc 99.10% <100.00%> (ø)
google/cloud/storage/internal/object_requests.h 97.50% <ø> (ø)
...gle/cloud/storage/tests/object_integration_test.cc 98.65% <100.00%> (+0.05%) ⬆️
google/cloud/storage/well_known_parameters.h 98.03% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan enabled auto-merge (squash) October 6, 2023 21:23
@coryan coryan merged commit d6fcb9c into googleapis:main Oct 6, 2023
54 checks passed
@coryan coryan deleted the feat-storage-support-matchGlob-list-in-objects branch October 6, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants