Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel): patch bazel #10498

Merged
merged 1 commit into from
Jan 6, 2023
Merged

chore(otel): patch bazel #10498

merged 1 commit into from
Jan 6, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jan 5, 2023

Manually update opentelemetry-cpp to a commit that includes open-telemetry/opentelemetry-cpp#1873

Otherwise the SDK will not build with bazel 6.0, which we need to use in our tests.

I do not want to wait on OpenTelemetry's release schedule. Also, I do not know how the bots will react. 🤷


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 93.98% // Head: 93.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (86cab06) compared to base (a60ecbe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10498      +/-   ##
==========================================
- Coverage   93.98%   93.97%   -0.01%     
==========================================
  Files        1627     1627              
  Lines      146846   146846              
==========================================
- Hits       138008   138004       -4     
- Misses       8838     8842       +4     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 98.78% <0.00%> (-1.22%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.33% <0.00%> (+0.33%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️
google/cloud/internal/async_rpc_details.h 100.00% <0.00%> (+5.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review January 5, 2023 23:54
@dbolduc dbolduc requested a review from a team as a code owner January 5, 2023 23:54
@dbolduc dbolduc merged commit 8e9a5cb into googleapis:main Jan 6, 2023
@dbolduc dbolduc deleted the otel-patch branch January 6, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants