feat: Provide opt-in debug logging #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazuma
force-pushed
the
pr/logging
branch
10 times, most recently
from
9e18ab5 to
79b6566
Compare
dazuma
force-pushed
the
pr/logging
branch
2 times, most recently
from
e9b6fcf to
e9c8a85
Compare
dazuma
changed the title
dazuma
force-pushed
the
pr/logging
branch
2 times, most recently
from
ceca647 to
d9f698d
Compare
aandreassa
approved these changes
Dec 4, 2024
aandreassa
approved these changes
Dec 4, 2024
tartakynov
reviewed
Dec 18, 2024
| @project_id ||= CredentialsLoader.load_gcloud_project_id | ||
| @client.fetch_access_token! if @client.needs_access_token? |
There was a problem hiding this comment.
@dazuma was this change intentional?
There was a problem hiding this comment.
@tartakynov Yes it was. Auth clients should be fetching tokens just-in-time when a request is actually made, rather than eagerly up front. Did this cause an issue?
There was a problem hiding this comment.
@dazuma This change also broke our codebase... We now get this error when trying to call BigQuery:
Google::Cloud::UnauthenticatedError: UnauthorizedUpgrading to 1.12.2 etc does not help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
loggerattribute to each credential type (via BaseClient) and a pass-through from the high-level Credential class. The value isnilby default, but when set, certain events such as JWT application and OAuth2 token exchange are logged. Tokens are obfuscated via sha256.