feat(common): Log requests and responses #1112
Conversation
dazuma
force-pushed
the
pr/common-logging
branch
7 times, most recently
from
be89659 to
3e27e01
Compare
dazuma
force-pushed
the
pr/common-logging
branch
from
3e27e01 to
aac8cf8
Compare
dazuma
force-pushed
the
pr/common-logging
branch
3 times, most recently
from
b35abcf to
3a06e57
Compare
dazuma
force-pushed
the
pr/common-logging
branch
2 times, most recently
from
9ac59b0 to
d1272d2
Compare
dazuma
force-pushed
the
pr/common-logging
branch
from
d1272d2 to
733776a
Compare
|
|
||
| class << self | ||
| # @private | ||
| def random_uuid4 |
There was a problem hiding this comment.
I vote for SecureRandom.uuid here, and then you don't even need to test it -- the algo looks nice though. We already use in a bunch of places for our repos and its a standard library.
There was a problem hiding this comment.
Main reason I chose to avoid SecureRandom here is that its internal implementation can theoretically block for brief periods of time (e.g. if /dev/urandom is being used), and for logging purposes we have a fairly strict requirement against that. That said, there is Random::Formatter (i.e. allowing Random.uuid) which I would use except it seems to require Ruby 3.1, and we're not quite scheduled to drop 3.0 support yet until next spring.
| @@ -64,6 +66,9 @@ class ServiceStub | |||
| # be used for intercepting calls before they are executed Interceptors are an EXPERIMENTAL API. | |||
| # @param channel_pool_config [::Gapic::ServiceStub:ChannelPool::Configuration] The configuration for channel | |||
| # pool. This argument will raise error when `credentials` is provided as a `::GRPC::Core::Channel`. | |||
| # @param logger [Logger,:default,nil] An explicit logger to use, or one | |||
There was a problem hiding this comment.
No action, just saying I probably prefer the docstring order used here.
Having the parameter name after @param is easier to see. Example in google-cloud-ruby
There was a problem hiding this comment.
Yes, agreed. A lot of our early development in google-cloud-ruby used the other ordering (type first). I think it might have been because earlier versions of YARD required that ordering. But I definitely prefer name-first now that YARD supports both.
dazuma
force-pushed
the
pr/common-logging
branch
from
733776a to
7ea86c8
Compare
dazuma
force-pushed
the
pr/common-logging
branch
from
7ea86c8 to
68565f9
Compare
No description provided.