Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix(deps): allow cachetools 5.0 for python 3.7+ #937

Merged
arithmetic1728 merged 7 commits into from
Jan 20, 2022
Merged

fix(deps): allow cachetools 5.0 for python 3.7+ #937

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
29821e8
fix(deps): allow cachetools 5.0 for python 3.7+
busunkim96 Dec 30, 2021
3156aa0
chore: remove split pin
busunkim96 Jan 20, 2022
27ff2f4
Merge branch 'main' into busunkim96-patch-1
busunkim96 Jan 20, 2022
476c5ca
Update setup.py
busunkim96 Jan 20, 2022
2a63324
🦉 Updates from OwlBot
gcf-owl-bot[bot] Jan 20, 2022
cef2f75
Merge branch 'busunkim96-patch-1' of https://github.com/googleapis/go…
gcf-owl-bot[bot] Jan 20, 2022
e3aad15
Merge branch 'main' into busunkim96-patch-1
arithmetic1728 Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@


DEPENDENCIES = (
"cachetools>=2.0.0,<5.0",
'cachetools>=2.0.0,<5.0; python_version < "3.7"',
'cachetools>=2.0.0,<6.0; python_version >= "3.7"',

@cdce8p cdce8p Jan 13, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'cachetools>=2.0.0,<5.0; python_version < "3.7"',
'cachetools>=2.0.0,<6.0; python_version >= "3.7"',
'cachetools>=2.0.0,<6.0',

That shouldn't be necessary. Pip can automatically resolve the compatible version. I.e. pip will choose <5.0 for Python 3.6.

@busunkim96 busunkim96 Jan 20, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I lost track of this PR. I've condensed this down to one pin as suggested.

"pyasn1-modules>=0.2.1",
# rsa==4.5 is the last version to support 2.7
# https://github.com/sybrenstuvel/python-rsa/issues/152#issuecomment-643470233
Expand Down