Skip to content

test: add asynctest to async dependencies #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
busunkim96 wants to merge 1 commit into from
Closed

test: add asynctest to async dependencies #627

busunkim96 wants to merge 1 commit into from

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 20, 2020 •
edited
Loading

aioresponses==0.7.0 seems to have a hard dependency on asynctest for python < 3.8. See pnuckowski/aioresponses#172

This adds asynctest to the test dependencies so the 3.6 and 3.7 unit test sessions pass.

@busunkim96 busunkim96 requested a review from a team as a code owner October 20, 2020 23:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2020
@tseaver
Copy link
Contributor

tseaver commented Oct 28, 2020

Superseded by #630.

@tseaver tseaver closed this Oct 28, 2020
@tseaver tseaver deleted the fix-async-tests branch October 28, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@software-dov software-dov Awaiting requested review from software-dov

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@busunkim96 @tseaver