fix(auth): Add temporary patch to workload cert logic to accomodate Cloud Run mis-configuration #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loud Run mis-configuration
yaoliugg
added a commit
to yaoliugg/google-auth-library-python
that referenced
this pull request
Dec 3, 2025
| ) | ||
| key_path = workload["key_path"] | ||
|
|
||
| # == BEGIN Temporary Cloud Run PATCH == |
Collaborator
There was a problem hiding this comment.
Please add a TODO: string somewhere giving some context, and letting us know how and when the patch can be removed. Maybe add a link to this PR or a bug too (is there a tracking bug that will be resolved when this can be removed?
Contributor
Author
There was a problem hiding this comment.
I created a github issue to track this at #1881 and assigned it to myself. Included this in the comments.
daniel-sanche
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a fallback logic to look for Cloud Run cert/keys in the well-known location if the cert config contains the exact incorrect cert/key paths AND the incorrect cert/key paths point to non-existent files.
Note: This patch will be reverted sometime in Jan 2026, after Cloud Run environment is updated with the correct cert configs. The revert will be tracked by #1881