Skip to content

Conversation

@cureprotocols
Copy link

This PR contributes to #1508 by adding complete type annotations to google/auth/exceptions.py.

✔️ Highlights:

  • Annotated all exception classes with explicit return types.
  • Replaced keyword-only arguments with **kwargs for Python 3.7 compatibility.
  • Ensured backward compatibility and preserved existing exception behavior.
  • Verified clean using: mypy --strict google/auth/exceptions.py

This continues the ongoing effort to fully type this library and improve static analysis support.

Let me know if any refinements are needed!

@cureprotocols cureprotocols requested review from a team as code owners April 3, 2025 01:46
@gkevinzheng gkevinzheng requested a review from a team as a code owner December 17, 2025 19:41
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 17, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 17, 2025
@chalmerlowe
Copy link
Contributor

This appears to be an autogenerated PR. Closing.

It links to an issue #1508 that appears to have nothing to do with the need for type hinting. It is part of a large collection of PRs issued by the same entity at the same time.

This update adds methods to the code that did not exist before (despite claiming to simply be a type hint update).

  • #L84 __init__
  • #L52 @property

Other examples include:
#1712 (comment)
#1711 (comment)

This was referenced Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants