Skip to content

Conversation

@clundin25
Copy link
Contributor

@clundin25 clundin25 requested review from a team as code owners July 25, 2023 21:52
Copy link
Contributor

@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One less dependency

@clundin25
Copy link
Contributor Author

Looks like mock.AsyncMock is gated by Python 3.8.

I'm considering if we should just gate the Async code to 3.8 in that case, since it's still in "Preview".

@sai-sunder-s @arithmetic1728 @BigTailWolf thoughts?

@BigTailWolf
Copy link
Contributor

Looks like mock.AsyncMock is gated by Python 3.8.

I'm considering if we should just gate the Async code to 3.8 in that case, since it's still in "Preview".

@sai-sunder-s @arithmetic1728 @BigTailWolf thoughts?

Do we currently have any from unittest.mock import AsyncMock in any test?
I searched across ed the repo and didn't see one of them.

@clundin25
Copy link
Contributor Author

@BigTailWolf It's found in the following files:

❯ rg "AsyncMock" -l
tests_async/oauth2/test__client_async.py
tests_async/oauth2/test_id_token.py
tests_async/oauth2/test_reauth_async.py
tests_async/oauth2/test_service_account_async.py
tests_async/oauth2/test_credentials_async.py
tests_async/transport/test_aiohttp_requests.py

@dvzrv
Copy link

dvzrv commented Mar 5, 2024

Hi! 👋

We are currently (finally) removing the python-mock package on Arch Linux.
I am therefore very interested in this getting merged and released. Are there still specific blockers?

@lfos
Copy link

lfos commented Feb 18, 2025

Are there any updates? It'd be great to get this updated and merged!

@musicinmybrain
Copy link

See also #1055, #1786.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use unittest.mock instead of mock

5 participants