-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: allow firebase/php-jwt v6 #391
Conversation
Bump - would be great to get merged in to enable meeting security SLAs! |
@ahthomsen for the record, firebase PHP-JWT offers a fix for this in v5.5, which this library supports. |
Co-authored-by: David Supplee <[email protected]>
Co-authored-by: David Supplee <[email protected]>
@dwsupplee @vishwarajanand comments addressed! PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please have @dwsupplee approve as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the tests 👍
This has been released in v1.21.0 |
see CVE-2021-46743 and GHSA-8xf4-w7qw-pjjw