Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow firebase/php-jwt v6 #391

Merged
merged 20 commits into from
Apr 13, 2022
Merged

feat!: allow firebase/php-jwt v6 #391

merged 20 commits into from
Apr 13, 2022

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Apr 4, 2022

@bshaffer bshaffer requested a review from a team as a code owner April 4, 2022 16:37
@bshaffer bshaffer changed the title [DO NOT MERGE] update to JWT v6 feat!: allow firebase/php-jwt v6 Apr 4, 2022
@ahthomsen
Copy link

Bump - would be great to get merged in to enable meeting security SLAs!

@bshaffer
Copy link
Contributor Author

bshaffer commented Apr 9, 2022

@ahthomsen for the record, firebase PHP-JWT offers a fix for this in v5.5, which this library supports.

src/OAuth2.php Outdated Show resolved Hide resolved
src/OAuth2.php Outdated Show resolved Hide resolved
src/OAuth2.php Outdated Show resolved Hide resolved
src/OAuth2.php Show resolved Hide resolved
src/OAuth2.php Outdated Show resolved Hide resolved
src/OAuth2.php Show resolved Hide resolved
bshaffer and others added 2 commits April 12, 2022 09:32
Co-authored-by: David Supplee <[email protected]>
Co-authored-by: David Supplee <[email protected]>
@bshaffer
Copy link
Contributor Author

@dwsupplee @vishwarajanand comments addressed! PTAL!

Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please have @dwsupplee approve as well.

Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the tests 👍

@bshaffer bshaffer merged commit 73392ba into main Apr 13, 2022
@bshaffer bshaffer deleted the update-firebase-jwt branch April 13, 2022 20:35
@bshaffer
Copy link
Contributor Author

This has been released in v1.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants