Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Byoid metrics framework #1232

Merged
merged 15 commits into from
Jul 14, 2023
Merged
5 changes: 5 additions & 0 deletions oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,11 @@ public GoogleCredentials createScoped(Collection<String> newScopes) {
return new AwsCredentials((AwsCredentials.Builder) newBuilder(this).setScopes(newScopes));
}

@Override
String getCredentialSourceType() {
return "aws";
}

private String retrieveResource(String url, String resourceName, Map<String, Object> headers)
throws IOException {
return retrieveResource(url, resourceName, HttpMethods.GET, headers, /* content= */ null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

import static com.google.common.base.Preconditions.checkNotNull;

import com.google.api.client.http.HttpHeaders;
import com.google.api.client.json.GenericJson;
import com.google.api.client.json.JsonObjectParser;
import com.google.auth.RequestMetadataCallback;
Expand Down Expand Up @@ -90,6 +91,7 @@ abstract static class CredentialSource implements java.io.Serializable {
private final CredentialSource credentialSource;
private final Collection<String> scopes;
private final ServiceAccountImpersonationOptions serviceAccountImpersonationOptions;
private ExternalAccountMetricsHandler metricsHandler;
aeitzman marked this conversation as resolved.
Show resolved Hide resolved

@Nullable private final String tokenInfoUrl;
@Nullable private final String serviceAccountImpersonationUrl;
Expand Down Expand Up @@ -224,6 +226,8 @@ protected ExternalAccountCredentials(
validateServiceAccountImpersonationInfoUrl(serviceAccountImpersonationUrl);
}

this.metricsHandler = new ExternalAccountMetricsHandler(this);

this.impersonatedCredentials = buildImpersonatedCredentials();
}

Expand Down Expand Up @@ -274,6 +278,11 @@ protected ExternalAccountCredentials(ExternalAccountCredentials.Builder builder)
validateServiceAccountImpersonationInfoUrl(serviceAccountImpersonationUrl);
}

this.metricsHandler =
builder.metricsHandler == null
? new ExternalAccountMetricsHandler(this)
: builder.metricsHandler;

this.impersonatedCredentials = buildImpersonatedCredentials();
}

Expand Down Expand Up @@ -505,6 +514,12 @@ protected AccessToken exchangeExternalCredentialForAccessToken(
requestHandler.setInternalOptions(options.toString());
}

// Set BYOID Metrics header.
HttpHeaders additionalHeaders = new HttpHeaders();
additionalHeaders.set(
MetricsUtils.API_CLIENT_HEADER, this.metricsHandler.getExternalAccountMetricsHeader());
requestHandler.setHeaders(additionalHeaders);

if (stsTokenExchangeRequest.getInternalOptions() != null) {
// Overwrite internal options. Let subclass handle setting options.
requestHandler.setInternalOptions(stsTokenExchangeRequest.getInternalOptions());
Expand Down Expand Up @@ -589,6 +604,10 @@ public ServiceAccountImpersonationOptions getServiceAccountImpersonationOptions(
return serviceAccountImpersonationOptions;
}

String getCredentialSourceType() {
return "unknown";
}

EnvironmentProvider getEnvironmentProvider() {
return environmentProvider;
}
Expand Down Expand Up @@ -663,8 +682,11 @@ static final class ServiceAccountImpersonationOptions implements java.io.Seriali

private final int lifetime;

final boolean customTokenLifetimeRequested;

ServiceAccountImpersonationOptions(Map<String, Object> optionsMap) {
if (!optionsMap.containsKey(TOKEN_LIFETIME_SECONDS_KEY)) {
customTokenLifetimeRequested = optionsMap.containsKey(TOKEN_LIFETIME_SECONDS_KEY);
if (!customTokenLifetimeRequested) {
lifetime = DEFAULT_TOKEN_LIFETIME_SECONDS;
return;
}
Expand Down Expand Up @@ -714,6 +736,7 @@ public abstract static class Builder extends GoogleCredentials.Builder {
@Nullable protected String workforcePoolUserProject;
@Nullable protected ServiceAccountImpersonationOptions serviceAccountImpersonationOptions;
@Nullable protected String universeDomain;
@Nullable protected ExternalAccountMetricsHandler metricsHandler;

protected Builder() {}

Expand All @@ -733,6 +756,7 @@ protected Builder(ExternalAccountCredentials credentials) {
this.workforcePoolUserProject = credentials.workforcePoolUserProject;
this.serviceAccountImpersonationOptions = credentials.serviceAccountImpersonationOptions;
this.universeDomain = credentials.universeDomain;
this.metricsHandler = credentials.metricsHandler;
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
/*
* Copyright 2023 Google LLC
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following disclaimer
* in the documentation and/or other materials provided with the
* distribution.
*
* * Neither the name of Google LLC nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

package com.google.auth.oauth2;

/**
* A handler for generating the x-goog-api-client header value for BYOID external account
* credentials.
*/
class ExternalAccountMetricsHandler implements java.io.Serializable {
private static final String SOURCE_KEY = "source";
private static final String IMPERSONATION_KEY = "sa-impersonation";
private static final String CONFIG_LIFETIME_KEY = "config-lifetime";
private static final String BYOID_METRICS_SECTION = "google-byoid-sdk";

private final boolean configLifetime;
private final boolean saImpersonation;
private String source;

/**
* Constructor for the external account metrics handler.
*
* @param creds the {@code ExternalAccountCredentials} object to set the external account metrics
* options from.
*/
ExternalAccountMetricsHandler(ExternalAccountCredentials creds) {
this.saImpersonation = creds.getServiceAccountImpersonationUrl() != null;
this.configLifetime =
creds.getServiceAccountImpersonationOptions().customTokenLifetimeRequested;
this.source = creds.getCredentialSourceType();
}

/**
* Gets the external account metrics header value for the x-goog-api-client header.
*
* @return the header value.
*/
String getExternalAccountMetricsHeader() {
return String.format(
"%s %s %s/%s %s/%s %s/%s",
MetricsUtils.getLanguageAndAuthLibraryVersions(),
BYOID_METRICS_SECTION,
SOURCE_KEY,
this.source,
IMPERSONATION_KEY,
this.saImpersonation,
CONFIG_LIFETIME_KEY,
this.configLifetime);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import com.google.api.client.json.GenericJson;
import com.google.api.client.json.JsonObjectParser;
import com.google.auth.oauth2.IdentityPoolCredentials.IdentityPoolCredentialSource.CredentialFormatType;
import com.google.auth.oauth2.IdentityPoolCredentials.IdentityPoolCredentialSource.IdentityPoolCredentialSourceType;
import com.google.common.io.CharStreams;
import java.io.BufferedReader;
import java.io.File;
Expand Down Expand Up @@ -192,6 +193,16 @@ public String retrieveSubjectToken() throws IOException {
return getSubjectTokenFromMetadataServer();
}

@Override
String getCredentialSourceType() {
if (((IdentityPoolCredentialSource) this.getCredentialSource()).credentialSourceType
== IdentityPoolCredentialSourceType.FILE) {
return "file";
} else {
return "url";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we consider using operand here to make is more concise to increase readability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean a ternary? I personally don't prefer them condition you are checking is long like this.

}

private String retrieveSubjectTokenFromCredentialFile() throws IOException {
String credentialFilePath = identityPoolCredentialSource.credentialLocation;
if (!Files.exists(Paths.get(credentialFilePath), LinkOption.NOFOLLOW_LINKS)) {
Expand Down
70 changes: 70 additions & 0 deletions oauth2_http/java/com/google/auth/oauth2/MetricsUtils.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
/*
* Copyright 2023 Google LLC
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following disclaimer
* in the documentation and/or other materials provided with the
* distribution.
*
* * Neither the name of Google LLC nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

package com.google.auth.oauth2;

import java.io.IOException;
import java.io.InputStream;
import java.util.Properties;

class MetricsUtils {
static final String API_CLIENT_HEADER = "x-goog-api-client";
private static final String authLibraryVersion = getAuthLibraryVersion();
private static final String javaLanguageVersion = System.getProperty("java.version");

/**
* Gets the x-goog-api-client header value for the current Java language version and the auth
* library version.
*
* @return the header value.
*/
static String getLanguageAndAuthLibraryVersions() {
return String.format("gl-java/%s auth/%s", javaLanguageVersion, authLibraryVersion);
}

private static String getAuthLibraryVersion() {
// Attempt to read the library's version from a properties file generated during the build.
// This value should be read and cached for later use.
String version = "unknown-version";
try (InputStream inputStream =
MetricsUtils.class.getResourceAsStream(
"/com/google/auth/oauth2/google-auth-library.properties")) {
if (inputStream != null) {
final Properties properties = new Properties();
properties.load(inputStream);
version = properties.getProperty("google-auth-library.version");
}
} catch (IOException e) {
// Ignore.
}
return version;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,11 @@ public PluggableAuthCredentials createScoped(Collection<String> newScopes) {
(PluggableAuthCredentials.Builder) newBuilder(this).setScopes(newScopes));
}

@Override
String getCredentialSourceType() {
return "executable";
}

public static Builder newBuilder() {
return new Builder();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ public void refreshAccessToken_withoutServiceAccountImpersonation() throws IOExc
AccessToken accessToken = awsCredential.refreshAccessToken();

assertEquals(transportFactory.transport.getAccessToken(), accessToken.getTokenValue());

// Validate metrics header is set correctly on the sts request.
Map<String, List<String>> headers =
transportFactory.transport.getRequests().get(3).getHeaders();
ExternalAccountCredentialsTest.validateMetricsHeader(headers, "aws", false, false);
}

@Test
Expand All @@ -142,18 +147,26 @@ public void refreshAccessToken_withServiceAccountImpersonation() throws IOExcept

AwsCredentials awsCredential =
(AwsCredentials)
AwsCredentials.newBuilder(AWS_CREDENTIAL)
AwsCredentials.newBuilder()
.setHttpTransportFactory(transportFactory)
.setAudience("audience")
.setSubjectTokenType("subjectTokenType")
.setTokenUrl(transportFactory.transport.getStsUrl())
.setTokenInfoUrl("tokenInfoUrl")
.setCredentialSource(buildAwsCredentialSource(transportFactory))
.setServiceAccountImpersonationUrl(
transportFactory.transport.getServiceAccountImpersonationUrl())
.setHttpTransportFactory(transportFactory)
.setCredentialSource(buildAwsCredentialSource(transportFactory))
.build();

AccessToken accessToken = awsCredential.refreshAccessToken();

assertEquals(
transportFactory.transport.getServiceAccountAccessToken(), accessToken.getTokenValue());

// Validate metrics header is set correctly on the sts request.
Map<String, List<String>> headers =
transportFactory.transport.getRequests().get(6).getHeaders();
ExternalAccountCredentialsTest.validateMetricsHeader(headers, "aws", true, false);
}

@Test
Expand All @@ -165,12 +178,15 @@ public void refreshAccessToken_withServiceAccountImpersonationOptions() throws I

AwsCredentials awsCredential =
(AwsCredentials)
AwsCredentials.newBuilder(AWS_CREDENTIAL)
AwsCredentials.newBuilder()
.setHttpTransportFactory(transportFactory)
.setAudience("audience")
.setSubjectTokenType("subjectTokenType")
.setTokenUrl(transportFactory.transport.getStsUrl())
.setTokenInfoUrl("tokenInfoUrl")
.setCredentialSource(buildAwsCredentialSource(transportFactory))
.setServiceAccountImpersonationUrl(
transportFactory.transport.getServiceAccountImpersonationUrl())
.setHttpTransportFactory(transportFactory)
.setCredentialSource(buildAwsCredentialSource(transportFactory))
.setServiceAccountImpersonationOptions(
ExternalAccountCredentialsTest.buildServiceAccountImpersonationOptions(2800))
.build();
Expand All @@ -187,6 +203,11 @@ public void refreshAccessToken_withServiceAccountImpersonationOptions() throws I
.parseAndClose(GenericJson.class);

assertEquals("2800s", query.get("lifetime"));

// Validate metrics header is set correctly on the sts request.
Map<String, List<String>> headers =
transportFactory.transport.getRequests().get(6).getHeaders();
ExternalAccountCredentialsTest.validateMetricsHeader(headers, "aws", true, true);
}

@Test
Expand Down
Loading