construct request once.

googleapis · Oct 2, 2024 · 1466f0d · 1466f0d
1 parent 05aa9cc
commit 1466f0d
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/oauth2_http/java/com/google/auth/oauth2/S2A.java b/oauth2_http/java/com/google/auth/oauth2/S2A.java
@@ -66,21 +66,25 @@ private S2AConfig getS2AConfigFromMDS() {
       transportFactory =
           Iterables.getFirst(
               ServiceLoader.load(HttpTransportFactory.class), OAuth2Utils.HTTP_TRANSPORT_FACTORY);
-    }  
+    }
+
+    HttpRequest request;
+    try {
+      request =
+              transportFactory.create().createRequestFactory().buildGetRequest(genericUrl);
+      request.setParser(parser);
+      request.getHeaders().set(METADATA_FLAVOR, GOOGLE);
+      request.setThrowExceptionOnExecuteError(false);
+    } catch (IOException e) {
+      return S2AConfig.createBuilder().build();
+    }
 
     for (int i = 0; i < MAX_MDS_PING_TRIES; i++) {
       try {
-        HttpRequest request =
-            transportFactory.create().createRequestFactory().buildGetRequest(genericUrl);
-        request.setParser(parser);
-        request.getHeaders().set(METADATA_FLAVOR, GOOGLE);
-        request.setThrowExceptionOnExecuteError(false);
         HttpResponse response = request.execute();
-
         if (!response.isSuccessStatusCode()) {
           continue;
         }
-
         InputStream content = response.getContent();
         if (content == null) {
           continue;