Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing public var used by subclasses #2254

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: add missing public var used by subclasses #2254

merged 1 commit into from
Apr 25, 2022

Conversation

bshaffer
Copy link
Contributor

The classes generated in google/apiclient-services are setting a local property $serviceName which isn't actually defined anywhere.

@bshaffer bshaffer requested a review from a team as a code owner April 22, 2022 20:02
saranshdhingra
saranshdhingra approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@saranshdhingra saranshdhingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshaffer bshaffer merged commit a9a27c2 into main Apr 25, 2022
@bshaffer bshaffer deleted the addmissingvar branch April 25, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saranshdhingra saranshdhingra saranshdhingra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @saranshdhingra