Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow usage of guzzlehttp/psr7 v2 #2128

Merged
merged 8 commits into from
Sep 20, 2021
Merged

Conversation

n00dl3
Copy link
Contributor

@n00dl3 n00dl3 commented Sep 13, 2021

replace deprecated function calls & bump min version of guzzlehttp/psr7 to 1.7+ or 2.0
related to #2099

@n00dl3 n00dl3 requested a review from a team as a code owner September 13, 2021 07:51
@google-cla
Copy link

google-cla bot commented Sep 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 13, 2021
@n00dl3
Copy link
Contributor Author

n00dl3 commented Sep 13, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Sep 13, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Sep 13, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@n00dl3
Copy link
Contributor Author

n00dl3 commented Sep 13, 2021

@googlebot I fixed it.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 13, 2021
@@ -51,7 +51,7 @@ class TestMediaTypeStream extends Stream
{
public $toStringCalled = false;

public function __toString()
public function __toString():string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't want to do that, I will remove this return type.

@google-cla
Copy link

google-cla bot commented Sep 13, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 13, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 13, 2021
@dwsupplee dwsupplee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 13, 2021
@dwsupplee
Copy link
Contributor

Thanks @n00dl3, this is great 👍.

@n00dl3
Copy link
Contributor Author

n00dl3 commented Sep 14, 2021

Hello, I added a version check in the test, tests pass for 7.3+ I had difficulties compiling 7.2 so I couldn't test with this php version, but I think it should be okay.
Unfortunately, I was not able to run the tests on php 5.6 on my computer due to some php7+ syntax in other test files, maybe I am misunderstanding something.

@n00dl3
Copy link
Contributor Author

n00dl3 commented Sep 15, 2021

This is the error I encountered, I guess tests are failing on php 5.6 since 1486680 .

@bshaffer bshaffer merged commit be74b9a into googleapis:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants